Skip to content
This repository was archived by the owner on Sep 30, 2021. It is now read-only.

Updated dead links, references to the "core", added more info on supported boards and corrected markdown.corrected form. #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pra-dan
Copy link

@pra-dan pra-dan commented Feb 26, 2020

No description provided.

@pra-dan
Copy link
Author

pra-dan commented Feb 27, 2020

Both the links redirect to different archived repositories but containing the same source code.

@per1234
Copy link
Contributor

per1234 commented Feb 27, 2020

They are not different repositories. The arduino-org/Ciao repository was transferred to bcmi-labs/Ciao (because the arduino-org organization has been phased out). bcmi-labs is one of Arduino's official organizations. There is no longer an arduino-org/Ciao repository. So the link: https://github.com/arduino-org/Ciao just redirects to https://github.com/bcmi-labs/Ciao. So why not make things clear by using the actual URL of the repository? It's also possible that the redirect will break at some time in the future, breaking your link. So let's use the link we know will stay good.

Co-Authored-By: per1234 <accounts@perglass.com>
Copy link
Author

@pra-dan pra-dan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged the mentioned changes.

@pra-dan
Copy link
Author

pra-dan commented Feb 28, 2020

Thanks for letting me know. Please have a look at it now.

@pra-dan pra-dan requested a review from per1234 February 29, 2020 14:14
@per1234 per1234 removed their request for review February 29, 2020 14:16
@pra-dan
Copy link
Author

pra-dan commented Mar 2, 2020

@per1234 should I revert the changes made to the links (although corrected by you and already merged by me) and instead create a new PR for the markdown edits? Please let me know :)

@per1234
Copy link
Contributor

per1234 commented Mar 2, 2020

Atomic commits and atomic pull requests are definitely a good thing, but in this case I think the changes are closely related enough that its reasonable for them to be in a single pull request. I'm not assigned to merging pull requests, so the opinion of the person doing the merge will be most important. I'm sure they'll let you know if they would like the PR split up.

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants