Skip to content

fix: bottom navigation current index #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 20, 2024

Conversation

HardikSJain
Copy link

@HardikSJain HardikSJain commented Jul 14, 2024

Fixed current index on page change for bottom nav bar.

  • used uri instead of location as 'location' is deprecated and shouldn't be used.
  • changed the condition to compare with the full path along with parent

Linkedin: https://www.linkedin.com/in/hardiksjain/

@HardikSJain
Copy link
Author

HardikSJain commented Jul 14, 2024

Fix: bottom nav index.

  • removed /home from the path, for correct comparison even when query or path parameters are passed

@HardikSJain
Copy link
Author

Updated the code to allow multiple navigation urls in the future.

@HardikSJain
Copy link
Author

changed the condition to compare with the full path including parent

@anshumandas anshumandas merged commit 8b3ecff into anshumandas:main Jul 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants