feat(cdk-experimental/radio): create radio group and button directives #31050
+215
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnermaciel
requested review from
adolgachev,
mmalerba and
ok7sai
and removed request for
a team
mmalerba
reviewed
May 8, 2025
| * </div> | ||
| * ``` | ||
| */ | ||
| @Directive({ |
There was a problem hiding this comment.
should this have some tests?
| private readonly _cdkRadioButtons = contentChildren(CdkRadioButton, {descendants: true}); | ||
|
|
||
| /** A signal wrapper for directionality. */ | ||
| protected textDirection = toSignal(this._directionality.change, { |
There was a problem hiding this comment.
can this just be textDirection = inject(Directionality).valueSignal?
| orientation = input<'vertical' | 'horizontal'>('vertical'); | ||
|
|
||
| /** Whether focus should wrap when navigating. */ | ||
| wrap = input(false, {transform: booleanAttribute}); // Radio groups typically don't wrap |
There was a problem hiding this comment.
given the comment should this be an input? or just hardcoded to false
| private _isViewInitialized = signal(false); | ||
|
|
||
| constructor() { | ||
| effect(() => { |
There was a problem hiding this comment.
could this just be afterRenderEffect and you skip the ngAfterViewInit stuff?
There was a problem hiding this comment.
I'm just now learning about afterRenderEffect but that sounds exactly like what we want haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.