Skip to content

fix(router-generator): Pathless Layout Route Renders Empty HTML #4003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+12 −1
Open

fix(router-generator): Pathless Layout Route Renders Empty HTML #4003

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6ad1af5
fix(router-core): filter routes with children that only have pathless…
leesb971204 Apr 16, 2025
5a76ed7
fix(router-core): remove filter for child routes in router
leesb971204 Apr 17, 2025
c641bce
fix(router-generator): include layout type in isNonPath node check
leesb971204 Apr 17, 2025
fc20f4a
fix(router-generator): add logic to set isNonPath for nodes with chil…
leesb971204 Apr 17, 2025
a5bf820
fix(router-generator): enhance isNonPath logic for parent nodes and a…
leesb971204 Apr 17, 2025
fcbc6bd
fix(router-generator): add check for pathless_layout first in updateI…
leesb971204 Apr 18, 2025
2cbf653
fix(router-generator): update determineNodePath to handle pathless_la…
leesb971204 Apr 18, 2025
415b821
fix(router-generator): refactor isNonPath condition and determineNode…
leesb971204 May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/router-generator/src/generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,13 +402,21 @@ export async function generator(config: Config, root: string) {
} else {
routeTree.push(node)
}
if (
node._fsRouteType === 'layout' &&
node.isVirtual &&
node.isVirtualParentRoute
) {
node.isNonPath = node.children?.every((d) => d.isNonPath)
}

routeNodes.push(node)
}

for (const node of onlyGeneratorRouteNodes) {
await handleNode(node)
}

checkRouteFullPathUniqueness(
preRouteNodes.filter(
(d) =>
Expand Down Expand Up @@ -835,7 +843,10 @@ function removeGroups(s: string) {
*/
function determineNodePath(node: RouteNode) {
return (node.path = node.parent
? node.routePath?.replace(node.parent.routePath ?? '', '') || '/'
? node.routePath?.replace(
node.parent.isNonPath ? '' : (node.parent.routePath ?? ''),
'',
) || '/'
: node.routePath)
}

Expand Down
Loading