Skip to content

ecdsa: der: use impl EncodeValue/DecodeValue on SignatureRef #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dishmaker
Copy link
Contributor

@dishmaker dishmaker commented May 12, 2025

This way we avoid using internals of der:

  • der::SliceWriter
  • der::SliceReader
  • tag.assert_eq
  • writer.sequence

@tarcieri
Copy link
Member

Those aren't really "internals": they're part of the public API, though this is perhaps more really idiomatic with how the rest of the library works.

Notably this doesn't really reduce code size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants