Implement TryFrom<Scalar/Projective/AffinePoint> for NonIdentity/ZeroScalar
#1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
try-from-non-identity-non-zero-scalar
branch
from
203fd36 to
671fe1c
Compare
|
These should probably carry a warning that they're not constant-time and at least document the constant-time alternative |
|
But the comparison itself is constant-time AFAIU. Handling the output isn't, but that seems communicated by the type to me as its not returning a Let me know if I'm making any sense here, otherwise I'm happy to add the warning. |
|
I added a link to the constant-time alternatives, its definitely useful regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement
TryFrom<Scalar> for NonZeroScalar,TryFrom<ProjectivePoint> for NonIdentity<ProjectivePoint>andTryFrom<AffinePoint> for NonIdentity<AffinePoint>in the same spirit as #1188 and #1190.