adding trust_remote_code and batch_size #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added trust_remote_code to the be default with True Also added the batch_size argument to be 32 as default option
Pringled
requested changes
May 4, 2025
| parser.add_argument( | ||
| "--trust-remote-code", | ||
| type=bool, | ||
| default=True, |
There was a problem hiding this comment.
I think False is a safer default to choose here, could you update to that?
| @@ -18,7 +18,7 @@ | |||
|
|
|||
|
|
|||
| def train_model( | |||
| model_name: str, train_txt: list[str], train_vec: np.ndarray, device: str = "cpu", vocab_size: int | None = None | |||
| model_name: str, train_txt: list[str], train_vec: np.ndarray, device: str = "cpu",batch_size: int= 32, vocab_size: int | None = None,trust_remote_code: bool=True | |||
There was a problem hiding this comment.
Small styling issue:
Suggested change
| model_name: str, train_txt: list[str], train_vec: np.ndarray, device: str = "cpu",batch_size: int= 32, vocab_size: int | None = None,trust_remote_code: bool=True | |
| model_name: str, train_txt: list[str], train_vec: np.ndarray, device: str = "cpu", batch_size: int= 32, vocab_size: int | None = None, trust_remote_code: bool=True |
There was a problem hiding this comment.
Also on a couple of other lines, see general PR comment.
Pringled
reviewed
May 4, 2025
| parser.add_argument( | ||
| "--batch-size", | ||
| type=int, | ||
| default=32, |
There was a problem hiding this comment.
This default doesn't match the default in https://github.com/MinishLab/tokenlearn/blob/main/tokenlearn/pretrain.py#L127, could you change to 256 so they match? Same for the default in the train_model function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added trust_remote_code to the be default with True Also added the batch_size argument to be 32 as default option