-
Notifications
You must be signed in to change notification settings - Fork 486
add MSM builtin #7074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add MSM builtin #7074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks basically OK, but I think we should change the inteface to elimitate pairs in PLC. You could also add changelog entries in plutus-core
and plutus-tx
saying that you've added preliminary versions of the MSM functions.
I think it's probably OK to merge this with the SRP in cabal.project
, but your changes will definitely have to be merged with cardano-base
before, eg, a node can be released that uses a Plutus release involving the SRP. @zliu41: is that reasonable?
@kwxm, the manual on adding a built-in clearly states
Should I also follow this for |
Actually I don't know. The thing about adding stuff at the end was mostly for |
The Haddock for Edit: no, wait. It looks as if the Haddock generator is grouping things together itself. I'm not sure how it does that. Anyway, just stick the new BLS functions in the same place as the old ones. |
@kwxm, for now, this PR only adds to
pass (I updated the interface). That said, this PR does break other packages (
|
Implement the
bls12_381_{G1/G2}_multiScalarMul
builtin forPlutus-Core
andPlutus-Tx
.The current implementation depends on a SRP of a PR against cardano-base (where the C bindings are added for the underlying functionality).