add scipy to runtime dependency #187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtavana
requested review from
ndgrigorian,
antonwolfy,
xaleryb and
ekomarova
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds SciPy as a runtime dependency to support the newly imported helper functions from SciPy in the mkl_fft.interfaces.scipy_fft module.
- Add
scipyto the core dependencies in pyproject.toml - Remove
scipyfrom the optionaltestextras - Include
scipyin both conda recipe metadata files
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pyproject.toml | Added scipy to dependencies and removed from tests |
| conda-recipe/meta.yaml | Added scipy under requirements |
| conda-recipe-cf/meta.yaml | Added scipy under requirements |
vtavana
force-pushed
the
scipy-runtime
branch
5 times, most recently
from
645f528 to
a9213ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #179, we added helper functions directly from SciPy for expanding the functionality of
mkl_fft.interfaces.scipy_fftmodule. This addition means thatscipyis now a runtime dependency. In this PR it is added to the project as a runtime dependency.