Skip to content

Fix npm instructions #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix npm instructions #261

wants to merge 1 commit into from

Conversation

silgal
Copy link

@silgal silgal commented Feb 23, 2022 •
edited
Loading

This change is Reviewable

@vercel
Copy link

vercel bot commented Feb 23, 2022

@silgal is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

@silgal silgal mentioned this pull request Feb 23, 2022
Open
@silgal
Copy link
Author

silgal commented May 18, 2022

ping

@flexbox
Copy link
Collaborator

flexbox commented Jun 16, 2022

Hey @silgal

Thanks for this PR.
Do you have more context? Or what should be tested? Thanks.

@flexbox flexbox added the State: Needs details Extra attention is needed label Jun 16, 2022
@silgal
Copy link
Author

silgal commented Jun 22, 2022 •
edited
Loading

Hey @silgal

Thanks for this PR. Do you have more context? Or what should be tested? Thanks.

Hi @flexbox ,

The context for npm_config_legacy_peer_deps=true is GeekyAnts/NativeBase#4369 (comment)

The context for @expo/next-adapter next-fonts is simply because it's out of sync with its yarn equivalent on the main branch, please see https://github.com/GeekyAnts/nativebase-docs/blame/main/docs/next/install-next.mdx#L135-L143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
State: Needs details Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silgal @flexbox