feature/SOF 7596 #328
Open
feature/SOF 7596 #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
VsevolodX
commented
Apr 10, 2025
VsevolodX
commented
- update: add materials_category schemas
- update: add reusable material schemas
- chore: generate dist
- chore: generate src py
VsevolodX
commented
Apr 14, 2025
| "items": { | ||
| "type": "integer" | ||
| }, | ||
| "minItems": 3, |
There was a problem hiding this comment.
Should be reused, here and below
| ], | ||
| "elements": [ | ||
| { | ||
| "id": 1, |
| @@ -0,0 +1,20 @@ | |||
| { | |||
There was a problem hiding this comment.
Should we place this under schema/material/reusable?
| { | ||
| "$id": "materials-category/defects/enums", | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "atomPlacementMethod": { |
There was a problem hiding this comment.
Don't we need a title to be able to use these in the Python runtime?
There was a problem hiding this comment.
We probably need to have separate enums for each
| "shape" | ||
| ], | ||
| "properties": { | ||
| "shape": { |
There was a problem hiding this comment.
Should be in a separate file - spatial_condition or something like that
| "slab_configuration" | ||
| ], | ||
| "properties": { | ||
| "phase_1_configuration": { |
There was a problem hiding this comment.
Should be properly formatted
There was a problem hiding this comment.
Let's make sure to have a JSON linter to assert all this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.