-
Notifications
You must be signed in to change notification settings - Fork 7
data import script #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
data import script #203
Conversation
@abs711 update the pixelmap_annotation function to capture the additional information needed by the platform. |
whole-slide image (various formats) | ||
Any format that is supported by `large image <https://girder.github.io/large_image/formats.html>`_ can be used. | ||
feature (.h5) | ||
This file contains a single array where each row is a feature embedding for the object. A single blank row should be prepended if the image contains non-object background pixels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of "the object" we could say "each superpixel"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also for the rest of the paragraph
They are defined at wsi resolution:
|
TL;DR nowhere important as far as I can tell. superpixelSize is one of the parameters defined in the mongoDB database (which is why we struggled with "missing jobId" last week"). It would be fetched here: but seems to only really be used if you ask for heatmaps with predictions from a chain here: heatmaps are disabled by default for now. So I would say we don't have have to address anything. Probably not relevant now, not sure about scenarios like:
I assume a default superpixelsize will be used for item 3, which may cause a mismatch. |
Great, thank you guys. I will update the README and will make a note of possible issues with superpixel size. Someone who is uploading data is unlikely to generate additional data through the interface, and so it may be mostly irrelevant. |
FYI I'm working on integrating my changes to work with AML for this and the superpixel_classification repository. |
@manthey Can I have the permissions to push changes? |
You should have an invite |
@manthey wondering how |
For any of the girder client upload function that take a progress call back, you should be able to do something like:
or as an obtuse lambda
I'm not sure if |
data_import.py
Outdated
@@ -251,7 +251,7 @@ def main(): | |||
features = [row[1] for row in inputs] | |||
pixelmaps = [row[2] for row in inputs] | |||
boxes = [row[3] for row in inputs] | |||
scales = [row[4] for row in inputs] | |||
scales = [int(row[4]) for row in inputs] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abs711 Should this be float? I don't think the scales will always be integer.
Adds a command-line script for data import or upload and documentation of data formats.