-
Notifications
You must be signed in to change notification settings - Fork 62
Fix KTX file format support and unify image reader logs #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix KTX file format support and unify image reader logs #335
Conversation
Now the engine says:
Note that I don't know if my KTX file is either valid either using a supported format. I produced it myself with a tool that says the support may not be good. At least the engine does not crash, and at this point it's enough to call this a success. So, thank you! |
Could you please share the map with KTX textures? I'll try to debug with problem on hands :) |
* Handle case for non-array cubemap textures. * Fix out of buffer read for numberOfMipmapLevels. * Better checks for KTX structure errors.
I added it to #244. |
Look good enough to merge. @slipher, @illwieckz what do you think? |
LGTM |
@slipher do you have anything more to say? |
<image type> image '<image path>' <log message>
.Fixes #244
@illwieckz could you please check the patch?