Skip to content

ITP_JAN_25 | HASAN DEMIROZ | Module-Structuring-and-Testing-Data | Sprint 3 #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Sprint-3/1-key-implement/1-get-angle-type.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@

function getAngleType(angle) {
if (angle === 90) return "Right angle";
else if (angle < 90) return "Acute angle";
else if (angle >90 && angle < 180) return "Obtuse angle";
else if (angle === 180) return "Straight angle";
else if (angle > 180 && angle < 360) return "Reflex angle";
// read to the end, complete line 36, then pass your test here
}

Expand Down Expand Up @@ -43,14 +47,19 @@ assertEquals(acute, "Acute angle");
// When the angle is greater than 90 degrees and less than 180 degrees,
// Then the function should return "Obtuse angle"
const obtuse = getAngleType(120);
assertEquals(obtuse, "Obtuse angle");
// ====> write your test here, and then add a line to pass the test in the function above

// Case 4: Identify Straight Angles:
// When the angle is exactly 180 degrees,
// Then the function should return "Straight angle"
// ====> write your test here, and then add a line to pass the test in the function above
const straight = getAngleType(180);
assertEquals(straight, "Straight angle");

// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
// ====> write your test here, and then add a line to pass the test in the function above
// ====> write your test here, and then add a line to pass the test in the function above
const reflex = getAngleType(200);
assertEquals(reflex, "Reflex angle");
15 changes: 14 additions & 1 deletion Sprint-3/1-key-implement/2-is-proper-fraction.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@
// write one test at a time, and make it pass, build your solution up methodically

function isProperFraction(numerator, denominator) {
if (numerator < denominator) return true;
if (numerator === 0 || denominator === 0) return false;
else if (Math.abs(numerator) < Math.abs(denominator))
return true;
else if (Math.abs(numerator) >= Math.abs(denominator)) return false;

}

// here's our helper again
Expand Down Expand Up @@ -40,14 +44,23 @@ assertEquals(improperFraction, false);
// target output: true
// Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
const negativeFraction = isProperFraction(-4, 7);
assertEquals(negativeFraction, true);
// ====> complete with your assertion

// Equal Numerator and Denominator check:
// Input: numerator = 3, denominator = 3
// target output: false
// Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
const equalFraction = isProperFraction(3, 3);
assertEquals(equalFraction, false);
// ====> complete with your assertion

// Stretch:
// What other scenarios could you test for?
const numeratorZero = isProperFraction(0, 3);
assertEquals( numeratorZero, false);

const denominatorZero = isProperFraction(5, 0);
assertEquals(denominatorZero, false);


32 changes: 28 additions & 4 deletions Sprint-3/1-key-implement/3-get-card-value.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@
// write one test at a time, and make it pass, build your solution up methodically
// just make one change at a time -- don't rush -- programmers are deep and careful thinkers
function getCardValue(card) {
if (rank === "A") return 11;
let rank = card.slice(0, -1);
if (rank.toUpperCase() === "A") return 11;
if (["J", "Q", "K", "10"].includes(rank.toUpperCase())) return 10;
let number = parseInt(rank);
if (number >= 2 && number <= 9) return number;
throw new Error("Invalid card rank.");
}

// You need to write assertions for your function to check it works in different cases
Expand All @@ -25,27 +30,46 @@ function assertEquals(actualOutput, targetOutput) {
// Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
// When the function getCardValue is called with this card string as input,
// Then it should return the numerical card value
const aceofSpades = getCardValue("A♠");
assertEquals(aceofSpades, 11);
const aceOfSpades = getCardValue("A♠");
assertEquals(aceOfSpades, 11);

// Handle Number Cards (2-10):
// Given a card with a rank between "2" and "9",
// When the function is called with such a card,
// Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
const fiveofHearts = getCardValue("5♥");
const fiveOfHearts = getCardValue("5♥");
assertEquals( fiveOfHearts, 5);
// ====> write your test here, and then add a line to pass the test in the function above

// Handle Face Cards (J, Q, K):
// Given a card with a rank of "10," "J," "Q," or "K",
// When the function is called with such a card,
// Then it should return the value 10, as these cards are worth 10 points each in blackjack.
const kingOfDiamonds = getCardValue("K♦");
assertEquals(kingOfDiamonds, 10);


// Handle Ace (A):
// Given a card with a rank of "A",
// When the function is called with an Ace,
// Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
const tenOfClubs = getCardValue("10♣");
assertEquals(tenOfClubs, 10);

// Handle Invalid Cards:
// Given a card with an invalid rank (neither a number nor a recognized face card),
// When the function is called with such a card,
// Then it should throw an error indicating "Invalid card rank."

// Invalid card should throw an error
try {
getCardValue("1♣"); // 1 is not a valid rank in a standard deck
} catch (error) {
assertEquals(error.message, "Invalid card rank.");
}

try {
getCardValue("Z♦"); // Z is not a valid card
} catch (error) {
assertEquals(error.message, "Invalid card rank.");
}
6 changes: 6 additions & 0 deletions Sprint-3/2-mandatory-rewrite/1-get-angle-type.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
function getAngleType(angle) {
if (angle === 90) return "Right angle";
// replace with your completed function from key-implement
if (angle < 90) return "Acute angle";
if (angle > 90 && angle < 180) return "Obtuse angle";
if (angle ===180 ) return "Straight angle";
if (angle > 180 && angle < 360) return "Reflex angle";
if ( angle === 360 ) return "Full rotation";
return "Invalid angle";

}

Expand Down
15 changes: 15 additions & 0 deletions Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,30 @@ test("should identify right angle (90°)", () => {
// Case 2: Identify Acute Angles:
// When the angle is less than 90 degrees,
// Then the function should return "Acute angle"
test("should identify acute angle (< 90°)", () => {
expect(getAngleType(45)). toEqual("Acute angle");
expect(getAngleType(10)). toEqual("Acute angle");
});

// Case 3: Identify Obtuse Angles:
// When the angle is greater than 90 degrees and less than 180 degrees,
// Then the function should return "Obtuse angle"
test("should identify obtuse angle(90 <angle <180)", () =>{
expect(getAngleType(120)).toEqual("Obtuse angle");
expect(getAngleType(100)).toEqual("Obtuse angle");
});

// Case 4: Identify Straight Angles:
// When the angle is exactly 180 degrees,
// Then the function should return "Straight angle"
test("should identify straight angle (180 )", () => {
expect(getAngleType(180)).toEqual("Straight angle");
});

// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
test("should identify reflex angle(180< angle <360)", () =>{
expect(getAngleType(270)).toEqual("Reflex angle");
expect(getAngleType(200)).toEqual("Reflex angle")
});
5 changes: 4 additions & 1 deletion Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
function isProperFraction(numerator, denominator) {
if (numerator < denominator) return true;
if(numerator ===0 || denominator ===0) return false;
else if (numerator < denominator) return true;
// add your completed function from key-implement here
else if (numerator >= denominator) return false;

}

module.exports = isProperFraction;
14 changes: 12 additions & 2 deletions Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
const isProperFraction = require("./2-is-proper-fraction");

test("should return true for a proper fraction", () => {
expect(isProperFraction(2, 3)).toEqual(true);
test("should return true for a proper fraction (2/3)",() => {
expect(isProperFraction(2,3)).toBe(true);
});

// Case 2: Identify Improper Fractions:
test("should return true for a improper fraction (3/1)",() => {
expect(isProperFraction(3,1)).toBe(false);
});

// Case 3: Identify Negative Fractions:
test("should return true for a negative fraction (-3/5)",() => {
expect(isProperFraction(-3,5)).toBe(true);
});

// Case 4: Identify Equal Numerator and Denominator:
test("should return true for a equal numerator and denominator fraction (5/5)",() => {
expect(isProperFraction(5,5)).toBe(false);
});

6 changes: 5 additions & 1 deletion Sprint-3/2-mandatory-rewrite/3-get-card-value.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
function getCardValue(card) {
// replace with your code from key-implement
return 11;
let rank = card.slice(0, -1);
if (rank === "A") return 11;
if (["J", "Q", "K", "10"].includes(rank)) return 10;
if(!isNaN(rank)) return parseInt(rank);
throw new Error("Invalid card rank.");
}
module.exports = getCardValue;
24 changes: 21 additions & 3 deletions Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,29 @@
const getCardValue = require("./3-get-card-value");

test("should return 11 for Ace of Spades", () => {
const aceofSpades = getCardValue("A♠");
expect(aceofSpades).toEqual(11);
const aceOfSpades = getCardValue("A♠");
expect(aceOfSpades).toEqual(11);
});

// Case 2: Handle Number Cards (2-10):
test("should return 7 for seven of Spades", () => {
const aceOfSpades = getCardValue("7♠");
expect(aceOfSpades).toEqual(7);
});

// Case 3: Handle Face Cards (J, Q, K):
test("should return 10 for King of Diamonds", () => {
const aceOfSpades = getCardValue("K♦");
expect(aceOfSpades).toEqual(10);
});

// Case 4: Handle Ace (A):
// Case 5: Handle Invalid Cards:
test("should return 10 for Ten or Clubs",() =>{
const aceOfSpades = getCardValue("5♠");
expect(aceOfSpades).toEqual(5);
});

// Case 5: Handle Invalid Cards:
test("should throw an error for an invalid card (Z♦)", () => {
expect(() => getCardValue("Z♦")).toThrow("Invalid card rank.");
});
3 changes: 2 additions & 1 deletion Sprint-3/3-mandatory-practice/implement/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
if(findCharacter==="") return 0;
else return stringOfCharacters.split(findCharacter).length -1;
}

module.exports = countChar;
31 changes: 30 additions & 1 deletion Sprint-3/3-mandatory-practice/implement/count.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const countChar = require("./count");
test("should count multiple occurrences of a character", () => {
const str = "aaaaa";
const char = "a";
const count = countChar(str, char);
let count = countChar(str, char);
expect(count).toEqual(5);
});

Expand All @@ -22,3 +22,32 @@ test("should count multiple occurrences of a character", () => {
// And a character char that does not exist within the case-sensitive str,
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.

test("should count multiple occurrences of l character", () => {
const str = "hello";
const char = "l";
let count = countChar(str, char);
expect(count).toEqual(2);
});

test("should return 0 if because of case-sensitivity",() =>{
const str = "Car";
const char = "c";
const count = countChar(str,char);
expect(count).toEqual(0);
});


test("should return 0 if character does not appears",() =>{
const str = "apple";
const char = "c";
const count = countChar(str,char);
expect(count).toEqual(0);
});

test("should return 0 if character is empty string",() =>{
const str = "apple";
const char = "";
const count = countChar(str,char);
expect(count).toEqual(0);
});
14 changes: 12 additions & 2 deletions Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
function getOrdinalNumber(num) {
return "1st";
let lastDigit = (num.toString()).slice(-1);
if(num > 10 && num < 14|| lastDigit >= 4) {return num + "th"}
else if (lastDigit == 1) return num + "st"
else if (lastDigit == 2) return num + "nd"
else if (lastDigit == 3) return num + "rd"

}

module.exports = getOrdinalNumber;
module.exports = getOrdinalNumber;

// 1st 11th 21st 31st
// 2nd 12th 22nd 32nd
// 3rd 13th 23rd 33rd

14 changes: 14 additions & 0 deletions Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,17 @@ const getOrdinalNumber = require("./get-ordinal-number");
test("should return '1st' for 1", () => {
expect(getOrdinalNumber(1)).toEqual("1st");
});

test("should return '2nd' for 2", () => {
expect(getOrdinalNumber(2)).toEqual("2nd");
});


test("should return '8th' for 8", () => {
expect(getOrdinalNumber(8)).toEqual("8th");
});


test("should return '31st' for 31", () => {
expect(getOrdinalNumber(31)).toEqual("31st");
});
16 changes: 14 additions & 2 deletions Sprint-3/3-mandatory-practice/implement/repeat.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
function repeat() {
return "hellohellohello";
function repeat(str, count) {
if (count < 0) {
throw new Error("Count must be a non-negative integer.");
}

if (count === 0) {
return "";
}

let result = "";
for (let i = 0; i < count; i++) {
result += str;
}
return result;
}

module.exports = repeat;
Loading