Skip to content

add Bewitchment compat #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • add compat with Bewitchment altarUpgrade, athameLoot, brew, cauldron, curse, distillery, fortune, frostfire, incense, oven, pet, ritual, sigil, and spinningWheel. applied getMaxItemInput where applicable. examples and i18n for those.
  • add bewitchment as an opt dep for curseforge purposes.
  • import net.minecraft.potion.PotionEffect by default to groovyscript, removed prior examples importing it.
  • add GroovyScriptCodeConverter.asGroovyCode(EntityEntry, boolean) as another way to get the code for entities.
  • make docgen oonly document the description of a method once.
  • add documentation defaults for ForgeRegistryWrapper for the add and remove methods.
  • set debug_factory_tech to false.

originally based off a branch by @mcadventurecity

@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label May 10, 2025
# Conflicts:
#	src/main/java/com/cleanroommc/groovyscript/registry/ForgeRegistryWrapper.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants