Skip to content

497 feature request add formulas 61 68 from nen en 1993 1 1 #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

GerjanDorgelo
Copy link
Contributor

Description

completes 6.1-6.8 from 1993-1-1. fixed 6.5 such that it alligns with the other comparison scripts in the BP project.

Fixes #497

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@GerjanDorgelo GerjanDorgelo self-assigned this Feb 21, 2025
@GerjanDorgelo GerjanDorgelo linked an issue Feb 21, 2025 that may be closed by this pull request
7 tasks
Copy link

Thank you so much for contributing to Blueprints! This is your Pull Request # 21 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

@SZeltaat SZeltaat self-requested a review March 5, 2025 15:35
@SZeltaat
Copy link
Contributor

SZeltaat commented Mar 5, 2025

@GerjanDorgelo If you don't mind, I'll pick this up soon.

@SZeltaat SZeltaat added the in review This MR has been reviewed, and changes are made accordingly label Apr 9, 2025
Copy link
Contributor

@SZeltaat SZeltaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Gerjan,
Great job! Just some changes to represent the original Eurocode more accurately 😉

| 6.1 | :x: | | Form6Dot1ElasticVerification |
| 6.2 | :heavy_check_mark: | | Form6Dot2UtilizationRatio |
| 6.3 | :heavy_check_mark: | | Form6Dot3ADeductionAreaStaggeredFastenerHoles |
| 6.4 | :x: | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add info for 6.4

Comment on lines 32 to 34
| 6.6 | :x: | | |
| 6.7 | :x: | | |
| 6.8 | :x: | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add info for 6.6 to 6.8

@@ -0,0 +1,93 @@
"""Formula 6.1 from NEN-EN 1993-1-1+C2+A1:2016: Chapter 6 - Ultimate limit state."""

from blueprints.codes.eurocode.nen_en_1992_1_1_c2_2011 import NEN_EN_1992_1_1_C2_2011
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong Eurocode

) -> None:
r"""Elastic verification with the yield criterion.

NEN-EN 1993-1-1+C2:2011 art.6.2.1(5) - Formula (6.1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is also wrong

gamma_m0: DIMENSIONLESS,
) -> bool:
"""Evaluates the formula, for more information see the __init__ method."""
raise_if_negative(sigma_x_ed=sigma_x_ed, sigma_z_ed=sigma_z_ed, tau_ed=tau_ed, f_y=f_y, gamma_m0=gamma_m0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gamma_m0 and f_y cannot be zero in this formula.

from blueprints.validations import raise_if_negative


class Form6Dot4AxialCompression(Formula):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class Form6Dot4AxialCompression(Formula):
class Form6Dot4AdditionalMoment(Formula):

) -> None:
r"""[$\Delta M_{Ed}$] Calculation of the additional moment [$Nmm$].

NEN-EN 1993-1-1+C2+A1:2016 art.6.2.2.5(4) - Formula (6.4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this info should be covered in this doc-string, especially the note:

image

image

n_ed : N
[$N_{Ed}$] Axial compression force [$N$].
e_n : MM
[$e_{N}$] Shift of the centroid of the effective area relative to the centre of gravity of the gross cross section [$mm$].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[$e_{N}$] Shift of the centroid of the effective area relative to the centre of gravity of the gross cross section [$mm$].
[$e_{N}$] Shift of the centroid of the effective area relative to the centre of gravity of the gross cross section [$mm$]. the method given in EN 1993-1-5 should be used to determine the possible shift [$e_{N}$] of the centroid of the effective area [$A_{eff$] relative to the centre of gravity of the gross cross section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check that the names are consistent with the actual names if you decide to accept my name suggestions 😉

f_y : MPA
[$f_y$] Yield strength of the material [$MPa$].
gamma_m0 : DIMENSIONLESS
[$\gamma_{M0}$] Partial safety factor for resistance of cross-sections whatever the class is.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[$\gamma_{M0}$] Partial safety factor for resistance of cross-sections whatever the class is.
[$\gamma_{M0}$] Partial safety factor for resistance of cross-sections, irrespective of the class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review This MR has been reviewed, and changes are made accordingly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[✨ Feature request]: Add formulas 6.1-6.8 from NEN_EN_1993_1_1
2 participants