Fix: Improve useTorchLight hook and add tests #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses issues with the
useTorchLight
hook to improve its reliability across different browsers and adds comprehensive testing.Key changes include:
turnOn
function:track.getCapabilities()
for torch detection.ImageCapture
API as a secondary method.applyConstraints
.turnOff
function:track.applyConstraints({ advanced: [{ torch: false }] })
.stream.applyConstraints
and unrelated RTCPeerConnection logic.onError
callback usage.getCapabilities
,applyConstraints
,ImageCapture
) before calls.useTorchLight.test.ts
with extensive tests using@testing-library/react-hooks
.MediaStream
,MediaStreamTrack
,ImageCapture
,navigator.vibrate
).@testing-library/react-hooks
,react
,react-dom
).ci.yml
workflow to run tests automatically on push to main and pull requests.package.json
.