1.21 advancements compat refactor #41
Conversation
There was a problem hiding this comment.
Looks good apart from a few things as listed in the review comments. I tested the one block pack and it seems to just change the root advancement title and description, but I'm assuming the actual advancement changes for one block coming later in a different PR given the description of the PR.
| @@ -0,0 +1,4 @@ | |||
| scoreboard players set skyvoid_advancements load.status 1 | |||
There was a problem hiding this comment.
The name should probably include that this is the one block advancements (e.g. skyvoid_oneblock_advancements). Similarly, the standard skyblock one should be named with that too (e.g. skyvoid_skyblock_advancements).
| id: 'skyvoid_advancements_standard' | ||
| name: 'SkyBlock Advancements' | ||
| author: 'EpyonProjects' | ||
| version: 2.0.0 |
There was a problem hiding this comment.
I'm assuming there is a major change since you changed the root advancement? Don't forget to change the load score in the load.mcfunction to match the major version (I can't comment on that file cuz it was moved and without changes).
There was a problem hiding this comment.
Hmm, no there wasn't exactly a reason for the major change other than that the pipeline was different. I have vague memories of having this conversation already, where it shouldn't matter because it's the same output / non-breaking for the player.
Moves the advancements from
/packs/extras/skyvoid_advancementstopacks/advancementsand set up a pipeline for future variants like One Block