Skip to content

Update build args and find program for API changes#38

Merged
Techatrix merged 4 commits into
zigtools:mainfrom
mattnite:passthru
May 30, 2026
Merged

Update build args and find program for API changes#38
Techatrix merged 4 commits into
zigtools:mainfrom
mattnite:passthru

Conversation

@mattnite

Copy link
Copy Markdown
Contributor

This does change the usage of hello client subcommand. Before we had an assumption that if only one arg was passedd in, you'd default to the hello server. If you passed more than one in, the second argument is expected to be a path to the server binary.

With the changes to Zig master, we can only pass through the args on the commandline, not inspect them. I've worked around this behavior by passing in the server binary explicitly using a named option over an arg positional.

mattnite added 2 commits May 30, 2026 10:03
This does change the usage of hello client subcommand. Before we had an
assumption that if only one arg was passedd in, you'd default to the
hello server. If you passed more than one in, the second argument is
expected to be a path to the server binary.

With the changes to Zig master, we can only pass through the args on the
commandline, not inspect them. I've worked around this behavior by
passing in the server binary explicitly using a named option over an arg
positional.
@codecov-commenter

codecov-commenter commented May 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.94%. Comparing base (b886a2b) to head (b868680).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files           3        3           
  Lines        1514     1515    +1     
=======================================
+ Hits         1498     1499    +1     
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Techatrix Techatrix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setup of the hello client example is a bit messy which I was planning to rework anyway so this should be fine.

The banner in the install steps on the README should be updated to this:

> [!NOTE]
> The default branch requires Zig `0.17.0-dev.601+0ff175b69` or later. Checkout the `0.16.x` branch when using Zig 0.16

I will take care of creating the 0.16.x branch.

Comment thread build.zig Outdated
@Techatrix Techatrix merged commit 9a25d49 into zigtools:main May 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants