Update build args and find program for API changes#38
Merged
Conversation
This does change the usage of hello client subcommand. Before we had an assumption that if only one arg was passedd in, you'd default to the hello server. If you passed more than one in, the second argument is expected to be a path to the server binary. With the changes to Zig master, we can only pass through the args on the commandline, not inspect them. I've worked around this behavior by passing in the server binary explicitly using a named option over an arg positional.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 3 3
Lines 1514 1515 +1
=======================================
+ Hits 1498 1499 +1
Misses 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Techatrix
requested changes
May 30, 2026
Techatrix
left a comment
Member
There was a problem hiding this comment.
The setup of the hello client example is a bit messy which I was planning to rework anyway so this should be fine.
The banner in the install steps on the README should be updated to this:
> [!NOTE]
> The default branch requires Zig `0.17.0-dev.601+0ff175b69` or later. Checkout the `0.16.x` branch when using Zig 0.16
I will take care of creating the 0.16.x branch.
Techatrix
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does change the usage of hello client subcommand. Before we had an assumption that if only one arg was passedd in, you'd default to the hello server. If you passed more than one in, the second argument is expected to be a path to the server binary.
With the changes to Zig master, we can only pass through the args on the commandline, not inspect them. I've worked around this behavior by passing in the server binary explicitly using a named option over an arg positional.