Add support for haskell-debugger#33
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Rajkumar Natarajan.
|
rajcspsg
force-pushed
the
haskell-debugger-support
branch
from
c4bf776 to
a7133e9
Compare
|
We require contributors to sign our Contributor License Agreement, and we don't have @rajcspsg on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
changed the title
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks for this!
Preliminary review, will do my best to get back to this in a timely manner again
There was a problem hiding this comment.
Let's call this language_server.rs instead
| name = "Haskell" | ||
| description = "Haskell support." | ||
| version = "0.2.1" | ||
| version = "0.2.2" |
There was a problem hiding this comment.
Ci will lint this, but that will be done after automatically (and will be minor at least)
| let request = dap_request_kind(adapter_name, merged.clone())?; | ||
| let configuration = serde_json::to_string(&merged) |
There was a problem hiding this comment.
We can swap this here to avoid the cloning, alternatively, that could just take this by ref?
Co-authored-by: Finn Evers <finn.evers@outlook.de>
| [[package]] | ||
| name = "zed_haskell" | ||
| version = "0.2.1" | ||
| version = "0.2.2" |
There was a problem hiding this comment.
@MrSubidubi should I decrement version here as well?
|
@MrSubidubi incorporated your review comments |
2 participants
closes #12
screen recording for debugger support