Use absolute paths for dotnet launched DLLs#89
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @FelixDamrau on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
info Only affects systems that do not have cs-language server installed as a global tool. Same problem is in roslyn.rs, but this usually doesn't start DLLs |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@FelixDamrau Turns out I've got csharp-ls installed as a global dotnet tool, so I went back and reproduced the failure using the relative DLL path from a cwd outside the extension, and confirmed that the absolute path resolves it fine. |
resolves #88
Zed spawns dotnet with its working directory set to the worktree root.
We must use absolute paths to reference the cs-language server, so the extension installed one can be found.