fix(storage): remove VerboseModule to make zarr.storage picklable (gh-4029)#4030
Open
NIK-TIGER-BILL wants to merge 1 commit into
Open
fix(storage): remove VerboseModule to make zarr.storage picklable (gh-4029)#4030NIK-TIGER-BILL wants to merge 1 commit into
NIK-TIGER-BILL wants to merge 1 commit into
Conversation
The VerboseModule subclass prevented from being serialized by cloudpickle (and therefore Dask). The only purpose of the subclass was to emit a deprecation warning when setting , which has been deprecated for a long time. Closes zarr-developers#4029 Signed-off-by: NIK-TIGER-BILL <nik.tiger.bill@github.com>
github-actions
Bot
added
the
needs release notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes #4029.
The
VerboseModulesubclass preventedzarr.storagefrom being pickled by cloudpickle (and therefore by Dask). The only purpose of the subclass was to emit a deprecation warning when settingzarr.storage.default_compressor, which has been deprecated for a long time.TODO:
docs/user-guide/*.mdchanges/