feat: improve command handling#159
Open
lucaaszsx wants to merge 7 commits into
Open
Conversation
There was a problem hiding this comment.
1 issue found across 12 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves command handling with early validation and better error messages, and adds dev environment awareness for command loading.
Changes
isProductiongetter based onNODE_ENVisBun || isDevto load commands fromsrc/in dev environment; addexists()method for early command validationexists()for early return before building context; distinguish between unknown command and failed execution error messagesSummary by cubic
Improves command handling with early validation and clearer errors, and loads commands from
src/in dev or Bun for faster local development. Addsconfig.isProductionbased onNODE_ENV.New Features
config.isProductiongetter (NODE_ENV === 'production').src/in Bun or non‑production; usesdist/in production Node.exists()for early command validation and short-circuiting.Bug Fixes
content-lengthwithNumber(...)in remote upload.appandRouterto resolve TS errors.Written for commit acd1523. Summary will update on new commits. Review in cubic