chore(ui): pin platform-react-ui 2.8.0 to activate version filter - #145
Merged
Merged
Conversation
…-4658) YPE-4658 already forwards the lists. This pin is the 4657-shaped web SDK that enforces them in Expo DOM WebViews. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@youversion/platform-react-ui/@youversion/platform-core2.8.0 pin.web-yv-providertype widen. The three filter lists andadditionalHeadersare first-class on the web provider now.x-yvp-sdkstamp winning: 2.8.0 writesX-YVP-Sdk, andHeaderswould combine a lowercase consumer key, so the wrapper now stamps that same name and strips other casings.AI working on behalf of Cam.
Test plan
pnpm typecheckproves the filter lists are real web-provider props (widen removed)packages/uiweb-yv-providertests: lists forward, empty arrays stay empty, SDK header winspackages/corehighlights / data-exchange tests:Authorizationstill present viaHeaders.getpnpm testandpnpm lintgreenexcludedVersionIds/permittedVersionIdson exampleYouVersionProviderand confirm the version picker WebView hides refused versions after Metro resolves 2.8.0Made with Cursor
Greptile Summary
The PR activates Expo DOM WebView version filtering by pinning the web platform packages to 2.8.0 and removing the temporary provider type widening.
Confidence Score: 5/5
The PR appears safe to merge, with the dependency pins, filter forwarding, and SDK-header precedence aligned across the changed code and tests.
The wrapper continues forwarding all provider properties, strips case-insensitive attribution-header collisions before stamping its own value, and consistently resolves the platform packages at 2.8.0; no concrete blocking or non-blocking defect remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Native[Native YouVersionProvider] -->|filter lists| DOM[Expo DOM wrapper] DOM -->|merge consumer headers| Stamp[React Native SDK stamp] Stamp --> Web[platform-react-ui 2.8.0] Web -->|enforced filters and attribution| API[YouVersion API]Reviews (1): Last reviewed commit: "chore(ui): pin platform-react-ui 2.8.0 s..." | Re-trigger Greptile
Context used (3)