Skip to content

chore(ui): pin platform-react-ui 2.8.0 to activate version filter - #145

Merged
cameronapak merged 1 commit into
mainfrom
cursor/cp/pin-react-ui-2.8.0-version-filter
Aug 20, 2026
Merged

chore(ui): pin platform-react-ui 2.8.0 to activate version filter#145
cameronapak merged 1 commit into
mainfrom
cursor/cp/pin-react-ui-2.8.0-version-filter

Conversation

@cameronapak

@cameronapak cameronapak commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • YPE-4658 (#142) shipped the RN forward path. This PR activates WebView enforcement via the 4657-shaped @youversion/platform-react-ui / @youversion/platform-core 2.8.0 pin.
  • Drops the local web-yv-provider type widen. The three filter lists and additionalHeaders are first-class on the web provider now.
  • Keeps the RN x-yvp-sdk stamp winning: 2.8.0 writes X-YVP-Sdk, and Headers would combine a lowercase consumer key, so the wrapper now stamps that same name and strips other casings.
  • Edits the existing unreleased minor changeset (API is not published yet) instead of adding a patch. Next Version Packages release is 1.3.0 with API + live enforcement. Removes the stale 2.7.0 pin sentence from the highlights changeset.

AI working on behalf of Cam.

Test plan

  • pnpm typecheck proves the filter lists are real web-provider props (widen removed)
  • packages/ui web-yv-provider tests: lists forward, empty arrays stay empty, SDK header wins
  • packages/core highlights / data-exchange tests: Authorization still present via Headers.get
  • pnpm test and pnpm lint green
  • Optional device check: set excludedVersionIds / permittedVersionIds on example YouVersionProvider and confirm the version picker WebView hides refused versions after Metro resolves 2.8.0

Made with Cursor

Greptile Summary

The PR activates Expo DOM WebView version filtering by pinning the web platform packages to 2.8.0 and removing the temporary provider type widening.

  • Forwards the now-supported version-filter properties through the web provider.
  • Adds case-insensitive SDK-header collision handling so the React Native attribution stamp wins.
  • Updates dependency resolutions, release notes, examples, and header assertions for the 2.8.0 behavior.

Confidence Score: 5/5

The PR appears safe to merge, with the dependency pins, filter forwarding, and SDK-header precedence aligned across the changed code and tests.

The wrapper continues forwarding all provider properties, strips case-insensitive attribution-header collisions before stamping its own value, and consistently resolves the platform packages at 2.8.0; no concrete blocking or non-blocking defect remains.

Important Files Changed

Filename Overview
packages/ui/src/lib/sdk-version.ts Adds case-insensitive removal of consumer SDK-header collisions before applying the React Native attribution stamp.
packages/ui/src/lib/web-yv-provider.ts Uses the upgraded web provider’s first-class prop contract and applies the centralized header merge.
packages/ui/package.json Pins the web UI and core platform dependencies to the aligned 2.8.0 release.
packages/core/package.json Pins the underlying platform core dependency to 2.8.0.
pnpm-lock.yaml Consistently resolves platform core, React hooks, and React UI packages at 2.8.0.
packages/ui/src/lib/tests/web-yv-provider.test.tsx Covers filter-list forwarding, empty-array preservation, and SDK-header precedence in the provider wrapper.
packages/ui/src/lib/tests/sdk-version.test.ts Covers the renamed SDK-header key and case-insensitive collision removal.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Native[Native YouVersionProvider] -->|filter lists| DOM[Expo DOM wrapper]
  DOM -->|merge consumer headers| Stamp[React Native SDK stamp]
  Stamp --> Web[platform-react-ui 2.8.0]
  Web -->|enforced filters and attribution| API[YouVersion API]
Loading

Reviews (1): Last reviewed commit: "chore(ui): pin platform-react-ui 2.8.0 s..." | Re-trigger Greptile

Context used (3)

…-4658)

YPE-4658 already forwards the lists. This pin is the 4657-shaped web SDK that enforces them in Expo DOM WebViews.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cameronapak cameronapak self-assigned this Aug 20, 2026

@Dustin-Kelley Dustin-Kelley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cameronapak
cameronapak merged commit 4a180f4 into main Aug 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants