-
Notifications
You must be signed in to change notification settings - Fork 5
feat(ui): let hosts supply locale and Reader Bible language (YPE-4813, YPE-5119) #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Dustin-Kelley
merged 10 commits into
main
from
cursor/ype-4813-reader-default-lang-e5f7
Aug 20, 2026
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
31cf74b
feat(ui): let hosts supply locale and Reader Bible language
cursoragent 38f823a
feat(demo): wire optional locale and Reader Bible language
cursoragent 5c76074
chore: merge main and retarget locale tests
Dustin-Kelley b795cdc
test(ui): fold YPE-5119 host-locale coverage into the Reader locale PR
Dustin-Kelley 44c51c5
Merge branch 'main' into cursor/ype-4813-reader-default-lang-e5f7
Dustin-Kelley 6ca164a
fix: guard againts case sensetivity
Dustin-Kelley ed0a079
fix(ui): apply provider locale during SSR
Dustin-Kelley 37a59fc
test(ui): assert SSR locale by language, not copy
Dustin-Kelley aae2b1d
test(ui): assert host locale by language, not copy
Dustin-Kelley e88925c
test(ui): wait for remove callback in vapor flash test
Dustin-Kelley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@youversion/platform-react-ui': minor | ||
| --- | ||
|
|
||
| Hosts can pass `locale` on `YouVersionProvider` to set SDK UI language and `Accept-Language` (including Verse of the Day copy in Expo WebViews), and `defaultLanguageId` / `languageId` on `BibleReader.Root` to seed the version picker. App locale and Bible language stay separate: `locale` does not pick a default Bible translation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| VITE_YVP_APP_KEY="" | ||
| VITE_YVP_API_HOST="api.youversion.com" | ||
| VITE_YVP_AUTH_REDIRECT_URL="http://localhost:5173" | ||
| # Optional. SDK UI language (BCP-47). Leave unset to follow the browser. | ||
| # VITE_YVP_LOCALE="es" | ||
| # Optional. Seeds the Reader version picker Bible language. Distinct from locale. | ||
| # VITE_YVP_DEFAULT_LANGUAGE_ID="es" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| /// <reference types="vite/client" /> | ||
|
|
||
| interface ImportMetaEnv { | ||
| readonly VITE_YVP_APP_KEY?: string; | ||
| readonly VITE_YVP_API_HOST?: string; | ||
| readonly VITE_YVP_AUTH_REDIRECT_URL?: string; | ||
| readonly VITE_YVP_LOCALE?: string; | ||
| readonly VITE_YVP_DEFAULT_LANGUAGE_ID?: string; | ||
| } | ||
|
|
||
| interface ImportMeta { | ||
| readonly env: ImportMetaEnv; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.