Skip to content

chore: sync react localization from platform-localization #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
platform-localization-pr-bot wants to merge 1 commit into from
Closed

chore: sync react localization from platform-localization #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/ui/src/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"interFontName": "Inter",
"sourceSerifFontName": "Source Serif",
"searchPlaceholder": "Search",
"booksHeading": "Books",
"backToBibleVersionsAriaLabel": "Back to Bible versions",
"bibleVersionsHeading": "Bible Versions",
"selectLanguageHeading": "Select Language",
Expand All @@ -43,9 +42,6 @@
"noChaptersAvailable": "No chapters available",
"noBibleSearchResults": "We're sorry, there are no Bible results for this search.",
"noVersionsFound": "No versions found",
"noLanguageSearchResults": "We're sorry, there are no results for this search.",
"languageSearchAriaLabel": "Search languages",
"versionSearchAriaLabel": "Search Bible versions",
"noRegionalLanguagesAvailable": "No regional languages available",
"suggestedTab": "Suggested",
Comment on lines 44 to 46

@greptile-apps greptile-apps Bot Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Missing versionSearchAriaLabel key breaks accessibility

"versionSearchAriaLabel" is removed from en.json, but it is still actively referenced in bible-version-picker.tsx at line 786 as aria-label={t('versionSearchAriaLabel')}. Since en is the configured fallbackLng in i18n/index.ts, removing this key from the fallback locale means every language (English included) will receive no match and i18next will fall back to rendering the raw key string "versionSearchAriaLabel" as the ARIA label — exposing an internal i18n key to screen-reader users instead of the intended human-readable "Search Bible versions".

Prompt To Fix With AI 
This is a comment left during a code review.
Path: packages/ui/src/i18n/locales/en.json
Line: 44-46

Comment:
**Missing `versionSearchAriaLabel` key breaks accessibility**

`"versionSearchAriaLabel"` is removed from `en.json`, but it is still actively referenced in `bible-version-picker.tsx` at line 786 as `aria-label={t('versionSearchAriaLabel')}`. Since `en` is the configured `fallbackLng` in `i18n/index.ts`, removing this key from the fallback locale means every language (English included) will receive no match and i18next will fall back to rendering the raw key string `"versionSearchAriaLabel"` as the ARIA label — exposing an internal i18n key to screen-reader users instead of the intended human-readable "Search Bible versions".

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Cursor Fix in Codex

"allLanguagesTab": "All ({{count}})",
Expand All @@ -59,5 +55,6 @@
"unreachableServerError": "The Bible server couldn't be reached. Check your connection and try again.",
"rateLimitedError": "The Bible service is receiving too many requests right now. Please wait a moment and try again.",
"serverError": "The Bible service is having trouble right now. Please try again in a moment.",
"genericPassageError": "We couldn't load this Bible passage. Please try again."
"genericPassageError": "We couldn't load this Bible passage. Please try again.",
"booksHeading": "Books"
}
Loading