Skip to content

Add ports to service - #15

Open
antirotor wants to merge 5 commits into
developfrom
use-ports
Open

Add ports to service#15
antirotor wants to merge 5 commits into
developfrom
use-ports

Conversation

@antirotor

Copy link
Copy Markdown
Member

Changelog Description

Pass ports definition to spawned service.

Additional review information

Portsd were not passed to the service. It can be now defined using ynput/ayon-frontend#1328

Closes #14

Testing notes:

  • Define service with ports (like [4000:4000])
  • Let ash to create and run it

@antirotor
antirotor requested a review from Copilot July 15, 2025 16:09
@antirotor antirotor self-assigned this Jul 15, 2025
@antirotor antirotor added the type: enhancement Improvement of existing functionality or minor addition label Jul 15, 2025

This comment was marked as outdated.

@antirotor
antirotor requested review from Copilot and martastain July 16, 2025 13:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds port mapping functionality to the service spawning system, allowing services to define and use port configurations when creating Docker containers. The change enables services to specify port mappings in the format [4000:4000] which are then passed to the Docker container creation process.

  • Adds ports parameter to the spawn method signature with proper type annotation
  • Implements port parsing logic to handle both single port and host:container port mapping formats
  • Integrates port configuration into the container creation workflow when network mode is not "host"

Comment thread ash/services.py Outdated
Comment thread ash/services.py Outdated
Comment thread ash/services.py Outdated
Comment thread ash/services.py Outdated
thanks copilot for the wrong suggestion
Comment thread ash/services.py
@antirotor
antirotor requested a review from martastain August 5, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service not exposing ports

3 participants