Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds port mapping functionality to the service spawning system, allowing services to define and use port configurations when creating Docker containers. The change enables services to specify port mappings in the format [4000:4000] which are then passed to the Docker container creation process.
- Adds
portsparameter to thespawnmethod signature with proper type annotation - Implements port parsing logic to handle both single port and host:container port mapping formats
- Integrates port configuration into the container creation workflow when network mode is not "host"
thanks copilot for the wrong suggestion
martastain
requested changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Pass ports definition to spawned service.
Additional review information
Portsd were not passed to the service. It can be now defined using ynput/ayon-frontend#1328
Closes #14
Testing notes:
[4000:4000])