[codex] Fix thread header actions menu drag region#62
Draft
brsbl wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the thread title/header three-dot actions menu on macOS desktop by keeping the title-area menu trigger out of the frameless-window drag region.
Root Cause
ThreadDetailHeaderrendersThreadActionsMenuin theAppPageHeadercenter/title slot. On macOS desktop,AppPageHeadermarks the whole header asapp-region: drag, while only the right-sideactionsslot was markedapp-region: no-drag. The title menu therefore lived inside a draggable region, allowing Electron to consume pointer interaction before Radix could open the dropdown. The standard manager timeline path made this especially visible because the menu is the only way to turn that view back off.Changes
actionsMenuinMACOS_WINDOW_NO_DRAG_CLASS.ThreadDetailHeaderregression test that asserts the title menu is rendered outside the macOS drag region.Validation
pnpm exec turbo run test --filter=@bb/app -- src/views/thread-detail/ThreadDetailHeader.test.tsxpnpm exec turbo run typecheck --filter=@bb/appwas attempted, but this checkout currently fails before this patch withCannot find module '@bb/host-daemon-contract'frompackages/server-contract/src/api-types.ts;packages/server-contract/node_modules/@bbis missing that workspace link.