[codex] Add default app open target#51
Draft
brsbl wants to merge 1 commit into
Draft
Conversation
brsbl
force-pushed
the
codex/default-app-open-target
branch
from
eac151c to
7c92fc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a generic macOS
Default Appworkspace open target that delegates file opening to LaunchServices withopen -- <path>. This lets Markdown files open in the user's configured default editor, such as Moss, instead of falling back to Finder when no allowlisted editor is installed.Separates file-preview "Open in editor" behavior from workspace-opening preferences so a stored Finder workspace target does not control file editor opens when an editor-like target is available.
Root Cause
bb only offered explicit allowlisted open targets from the host daemon. On machines without one of those editors installed, the fallback target could be Finder, so file-preview editor buttons could focus Finder instead of opening Markdown in the configured default editor.
Update Notes
origin/main(8ca421ae).HOST_DAEMON_PROTOCOL_VERSIONto25so dev restart/stale-daemon detection notices the local contract enum change.Validation
pnpm exec turbo run typecheck --filter=@bb/host-daemon-contract --filter=@bb/host-daemon --filter=@bb/app— passed, 3/3 packages.pnpm exec turbo run test --filter=@bb/host-daemon-contract— passed, 32 tests.pnpm exec turbo run test --filter=@bb/app— passed, 619 tests.pnpm exec turbo run test --filter=@bb/host-daemon -- src/workspace-open-targets.test.ts— passed, 12 tests.Note: full
@bb/host-daemonpackage test was also attempted and hit unrelated integration timeout flakes; the touched host-daemon path is covered by the targeted workspace-open-target test above.