Skip to content

fix(packaging): declare MIT license expression#69

Merged
carldebilly merged 1 commit into
yllibed:mainfrom
autocarl:agent/issue-68-nuget-license
Jul 16, 2026
Merged

fix(packaging): declare MIT license expression#69
carldebilly merged 1 commit into
yllibed:mainfrom
autocarl:agent/issue-68-nuget-license

Conversation

@autocarl

Copy link
Copy Markdown
Contributor

Summary

  • declare the repository's MIT license as a NuGet PackageLicenseExpression
  • centralize the metadata in src/Directory.Build.props so every packable Repl project inherits it
  • ensure NuGet consumers no longer see the published packages as having no license

Closes #68

Validation

  • dotnet restore src/Repl.slnx
  • dotnet pack src/Repl.slnx -c Release --no-restore -p:WarnOnPackingNonPackableProject=false
    • inspected all 10 generated .nupkg archives
    • verified every .nuspec contains <license type="expression">MIT</license>
  • dotnet build src/Repl.slnx -c Release -warnaserror --no-restore
    • 0 warnings, 0 errors
  • dotnet test --solution src/Repl.slnx -c Release --no-build --no-restore
    • 1,312 passed, 0 failed, 1 skipped (opt-in MCP Inspector external-toolchain smoke)

@autocarl

Copy link
Copy Markdown
Contributor Author

CI note: Build, Test, Pack is red because the dorny/test-reporter step cannot create a check for this fork PR (Resource not accessible by integration). The job's Restore, Build, and Test steps all succeeded; Pack was then skipped because the reporter step had failed.

I validated the exact GitHub merge tree (db43461275572ad8cc2362532bbe67aafe93690d) locally:

  • dotnet pack src/Repl.slnx -c Release --no-restore -p:WarnOnPackingNonPackableProject=false
  • 10 .nupkg archives produced and inspected
  • all 10 .nuspec files contain <license type="expression">MIT</license>
  • strict Release build: 0 warnings, 0 errors
  • full test suite: 1,312 passed, 0 failed, 1 opt-in external-toolchain smoke skipped

Failing job: https://github.com/yllibed/repl/actions/runs/29460470963/job/87502690109

@carldebilly
carldebilly merged commit d912bcb into yllibed:main Jul 16, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MIT license metadata to all NuGet packages

2 participants