feat(stark): single-source constraints — one definition per constraint, verified cross-version [stacked on #763]

cross_verify_examples.log

@@ -0,0 +1,31 @@
+==> Refs
+   OLD 88adbfa6 -> 88adbfa64c
+   NEW f2d34efd -> f2d34efd01
+Preparing worktree (detached HEAD 88adbfa6)
+==> Building examples_cli @ 88adbfa64c -> cli_old
+==> Building examples_cli @ f2d34efd01 -> cli_new
+==> Cross-verifying 11 examples, both directions
+PASS prove-NEW-verify-OLD : simple_fibonacci
+PASS prove-OLD-verify-NEW : simple_fibonacci
+PASS prove-NEW-verify-OLD : fibonacci_2_columns
+PASS prove-OLD-verify-NEW : fibonacci_2_columns
+PASS prove-NEW-verify-OLD : fibonacci_2_cols_shifted
+PASS prove-OLD-verify-NEW : fibonacci_2_cols_shifted
+PASS prove-NEW-verify-OLD : fibonacci_multi_column
+PASS prove-OLD-verify-NEW : fibonacci_multi_column
+PASS prove-NEW-verify-OLD : quadratic_air
+PASS prove-OLD-verify-NEW : quadratic_air
+PASS prove-NEW-verify-OLD : fibonacci_rap
+PASS prove-OLD-verify-NEW : fibonacci_rap
+PASS prove-NEW-verify-OLD : dummy_air
+PASS prove-OLD-verify-NEW : dummy_air
+PASS prove-NEW-verify-OLD : simple_addition
+PASS prove-OLD-verify-NEW : simple_addition
+PASS prove-NEW-verify-OLD : read_only_memory
+PASS prove-OLD-verify-NEW : read_only_memory
+PASS prove-NEW-verify-OLD : read_only_memory_logup
+PASS prove-OLD-verify-NEW : read_only_memory_logup
+PASS prove-NEW-verify-OLD : multi_table_lookup
+PASS prove-OLD-verify-NEW : multi_table_lookup
+
+==> RESULT: all 11 examples cross-verify in both directions.

crypto/math/src/field/extensions_goldilocks.rs

@@ -199,6 +199,11 @@ impl IsField for Degree2GoldilocksExtensionField {
 }
 
 impl IsSubFieldOf<Degree2GoldilocksExtensionField> for GoldilocksField {
+    // The base×ext ops run in the constraint-eval hot loop from downstream
+    // crates; these impls are concrete (non-generic), so without the
+    // attribute they compile as cross-crate calls under the default
+    // no-LTO release profile — unlike the #[inline(always)] IsField ops.
+    #[inline(always)]
     fn mul(
         a: &Self::BaseType,
         b: &<Degree2GoldilocksExtensionField as IsField>::BaseType,
@@ -208,6 +213,7 @@ impl IsSubFieldOf<Degree2GoldilocksExtensionField> for GoldilocksField {
         [c0, c1]
     }
 
+    #[inline(always)]
     fn add(
         a: &Self::BaseType,
         b: &<Degree2GoldilocksExtensionField as IsField>::BaseType,
@@ -224,6 +230,7 @@ impl IsSubFieldOf<Degree2GoldilocksExtensionField> for GoldilocksField {
         Ok(<Self as IsSubFieldOf<Degree2GoldilocksExtensionField>>::mul(a, &b_inv))
     }
 
+    #[inline(always)]
     fn sub(
         a: &Self::BaseType,
         b: &<Degree2GoldilocksExtensionField as IsField>::BaseType,
@@ -233,6 +240,7 @@ impl IsSubFieldOf<Degree2GoldilocksExtensionField> for GoldilocksField {
         [c0, c1]
     }
 
+    #[inline(always)]
     fn embed(a: Self::BaseType) -> <Degree2GoldilocksExtensionField as IsField>::BaseType {
         [FpE::from_raw(a), FpE::zero()]
     }
@@ -410,6 +418,12 @@ impl IsField for Degree3GoldilocksExtensionField {
 }
 
 impl IsSubFieldOf<Degree3GoldilocksExtensionField> for GoldilocksField {
+    // The base×ext ops run in the constraint-eval hot loop from downstream
+    // crates (the evaluator's eval·β fold and every LogUp fingerprint term);
+    // these impls are concrete (non-generic), so without the attribute they
+    // compile as cross-crate calls under the default no-LTO release profile —
+    // unlike the #[inline(always)] IsField ops.
+    #[inline(always)]
     fn mul(
         a: &Self::BaseType,
         b: &<Degree3GoldilocksExtensionField as IsField>::BaseType,
@@ -420,6 +434,7 @@ impl IsSubFieldOf<Degree3GoldilocksExtensionField> for GoldilocksField {
         [c0, c1, c2]
     }
 
+    #[inline(always)]
     fn add(
         a: &Self::BaseType,
         b: &<Degree3GoldilocksExtensionField as IsField>::BaseType,
@@ -436,6 +451,7 @@ impl IsSubFieldOf<Degree3GoldilocksExtensionField> for GoldilocksField {
         Ok(<Self as IsSubFieldOf<Degree3GoldilocksExtensionField>>::mul(a, &b_inv))
     }
 
+    #[inline(always)]
     fn sub(
         a: &Self::BaseType,
         b: &<Degree3GoldilocksExtensionField as IsField>::BaseType,
@@ -446,6 +462,7 @@ impl IsSubFieldOf<Degree3GoldilocksExtensionField> for GoldilocksField {
         [c0, c1, c2]
     }
 
+    #[inline(always)]
     fn embed(a: Self::BaseType) -> <Degree3GoldilocksExtensionField as IsField>::BaseType {
         [FpE::from_raw(a), FpE::zero(), FpE::zero()]
     }

crypto/stark/Cargo.toml

@@ -37,6 +37,7 @@ web-sys = { version = "0.3.64", features = ['console'], optional = true }
 serde_cbor = { version = "0.11.1" }
 
 [dev-dependencies]
+math = { path = "../math", features = ["test-utils"] }
 criterion = { version = "0.4", default-features = false }
 env_logger = "*"
 test-log = { version = "0.2.11", features = ["log"] }
@@ -78,6 +79,10 @@ dwarf-debug-info = false
 # Should we omit the default import path
 omit-default-module-path = false
 
+[[example]]
+name = "examples_cli"
+required-features = ["test-utils"]
+
 [[bench]]
 name = "prover_benchmark"
 harness = false