perf(continuations): Emit COMMIT output on the Memory bus #759
Draft
nicole-graus wants to merge 2 commits into
Draft
perf(continuations): Emit COMMIT output on the Memory bus #759nicole-graus wants to merge 2 commits into
nicole-graus wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In continuations, COMMIT output was verified per epoch, needing extra logic to check the right substring of committed bytes and a driver-trusted concatenation of the per-epoch output slices. COMMIT output is really a global property.
What changed
is_register→domain, now0RAM /1register /2commit) instead of a dedicatedCommitbus.domainis pinned to{0,1}withIS_BITin MEMW/MEMW_ALIGNED so the commit domain stays disjoint.