test surrogate pair encoding boundary - #1336
Draft
yagop wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a v2 encoder regression test that places an astral Unicode character across the 2048 UTF-16-code-unit boundary from issue #1335.
Why
The legacy transport's transitive
qsencoder split surrogate pairs at 1024-code-unit chunk boundaries and corrupted the following character. V2 uses the platform's nativeURLSearchParamsand is not affected, but this test preserves that behavior if the transport changes later.Impact
No runtime behavior changes. The test verifies that the exact HTML payload survives form encoding unchanged.
Validation
bun test test/unit/encode.test.tsnpm run typecheck:testgit diff --check