Fix template.create argument parser signature#407
Merged
Conversation
PyXmlSec_TemplateCreate still used the format string `O&O!O!|zzz:create` and passed a third optional string argument, even though `template.create()` only accepts two optional string parameters: `id` and `ns`. Update the parser to use `|zz:create` and remove the stray extra `&id` argument so the C binding matches the Python API. This fixes the runtime failure: SystemError: more argument specifiers than keyword list entries (remaining format:'z:create')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyXmlSec_TemplateCreate still used the format string
O&O!O!|zzz:createand passed a third optional string argument, even thoughtemplate.create()only accepts two optional string parameters:idandns.Update the parser to use
|zz:createand remove the stray extra&idargument so the C binding matches the Python API.This fixes the runtime failure:
SystemError: more argument specifiers than keyword list entries (remaining format:'z:create')