Repository navigation
tests: remove Big Endian–specific compressed size assertion (from #720) - #745
Merged
Merged
Conversation
The test previously hardcoded an expected compressed size for BIG_ENDIAN platforms. With recent changes to Snappy’s compression logic, the output size is now identical on both little-endian and big-endian systems, making the endianness-specific assertion invalid. Signed-off-by: Yasir Ashfaq <Yasir.Ashfaq1@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carries over #720 by @yasiribmcon; the commit and its authorship are unchanged. That PR couldn't be updated to current
main, and its CI never ran.batchingOfWritesShouldNotAffectCompressedDataSizehardcoded an expected compressed size of 90992 for big-endian platforms. With Snappy 1.1.10, s390x produces the same size as other little-endian x86 platforms, so the extra case made the test fail on s390x.Closes #720.
🤖 Generated with Claude Code