contours: handle infinite nan coords#2749
Merged
brendancol merged 3 commits intoJun 1, 2026
Merged
Conversation
|
Hi @Melissari1997, thanks for the PR! Would you mind filing a quick New contributor introduction issue when you get a chance? It helps us point you at issues that fit what you'd like to work on. Most fields are optional. Reviewing your PR doesn't depend on it, just a friendly nudge. |
Melissari1997
changed the title
brendancol
approved these changes
May 31, 2026
…ay-contrib#2704) After rebasing onto the upstream commit that introduced TestInfHandling with xfail(strict=True) markers, the branch ended up with two classes of the same name in test_contour.py. Python silently shadows the first definition, so pytest only collected the second (upstream) class, which still carried the xfail markers. The now-fixed np.isfinite guard caused those tests to pass, producing XPASS(strict) CI failures on macOS/3.14. - Remove the duplicate TestInfHandling block introduced by the rebase - Drop the xfail(strict=True) decorators from test_inf_corner_no_nan_coords
Melissari1997
force-pushed
the
fix/2704-contours-infinite-nan-coords
branch
from
d0d46f5 to
e11043e
Compare
Contributor
Author
|
Apparently my fork wasn't in sync with the official repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2704
This PR fixes the contour generation to properly handle input data containing infinite values. The marching squares algorithm now skips quadrilaterals with non-finite corners instead of producing invalid output or raising errors.
Key change:
AI-assisted review
AI-assisted review notes
The xarray-spatial review workflow was run against this change.
Issues found and addressed:
np.inf,-np.inf)Open concerns:
Tests
Added tests in
test_contour.pycovering:np.infvalues in input arrays-np.infvalues in input arrays