Skip to content

Revert xcp-networkd: dhclient cleanup (#7138)#7159

Merged
changlei-li merged 5 commits into
xapi-project:masterfrom
xcp-ng:dev/srt/master/dhcp-client-cleanup-revert
Jul 2, 2026
Merged

Revert xcp-networkd: dhclient cleanup (#7138)#7159
changlei-li merged 5 commits into
xapi-project:masterfrom
xcp-ng:dev/srt/master/dhcp-client-cleanup-revert

Conversation

@semarie

@semarie semarie commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Revert xcp-networkd: dhclient cleanup (#7138) after regression spotted.

@semarie

semarie commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Cc @minglumlu @changlei-li

@changlei-li

Copy link
Copy Markdown
Contributor

Thank you.
I see 8109f32 is not reverted. In some case, the Ip.flush_ip_addr runs twice and in some case it may not run as @last-genius's comment if exception is raised. So there is still some subtle difference.
How about revert them all?

@semarie semarie force-pushed the dev/srt/master/dhcp-client-cleanup-revert branch from aa0bd27 to e7e6cba Compare July 2, 2026 05:49
@semarie

semarie commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

My bad. My revert range seems to not has been inclusive. Fixed.

semarie added 5 commits July 2, 2026 07:58
…public interface"

This reverts commit 616b58c.

Signed-off-by: Sebastien Rodot <sebastien.rodot@vates.tech>
This reverts commit 83e7241.

Signed-off-by: Sebastien Rodot <sebastien.rodot@vates.tech>
This reverts commit 2ea48ef.

Signed-off-by: Sebastien Rodot <sebastien.rodot@vates.tech>
…assigned addresses."

This reverts commit 0d3b9a6.

Signed-off-by: Sebastien Rodot <sebastien.rodot@vates.tech>
… the interface if running and to unconfigure addresses."

This reverts commit 8109f32.

Signed-off-by: Sebastien Rodot <sebastien.rodot@vates.tech>
@semarie semarie force-pushed the dev/srt/master/dhcp-client-cleanup-revert branch from e7e6cba to 3fda4fa Compare July 2, 2026 05:58
@changlei-li changlei-li added this pull request to the merge queue Jul 2, 2026
Merged via the queue into xapi-project:master with commit 2f29f5e Jul 2, 2026
23 of 24 checks passed
@semarie semarie deleted the dev/srt/master/dhcp-client-cleanup-revert branch July 2, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants