Fix audio on resume#9
Open
nkay08 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue, where sometimes audio fails to work when resuming from hibernation.
See issue #8 .
When I manually executed the commands
systemctl --user restart pipewire pipewire-pulse wireplumberit started to work again - at least in my cases.Restarting these audio services will probably do no harm.
This change adds an additional script and service file that executes the mentioned command.
I also replaced all custom paths in the script with variables. This is just my opinion, but I don't like copy-pasted paths within code. I think this makes it easier if changes need to be implemented. Naming of the variables if of course subjective. If this is unwanted, 492728b could be reverted.