fix: Deprecated useAppConfig in favour of getAppConfig#2487
Open
fkatsuhiro wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
pkg/wxt
nishu-murmu
changed the title
Updated logger usage to use wxt.logger instead of logger.
nishu-murmu
approved these changes
Jul 5, 2026
nishu-murmu
left a comment
nishu-murmu
left a comment
Collaborator
There was a problem hiding this comment.
@fkatsuhiro
Use wxt logger instead of consola logger.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2487 +/- ##
==========================================
+ Coverage 79.32% 79.43% +0.10%
==========================================
Files 134 134
Lines 4005 4006 +1
Branches 910 910
==========================================
+ Hits 3177 3182 +5
+ Misses 736 734 -2
+ Partials 92 90 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
Thank you for your revewing and updating! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Follow up to #1911. This PR marks the old
useAppConfigfunction as deprecated to prepare for its complete removal in v1.0.Since
getAppConfighas already been introduced as an alias in #2144, this change ensures users are properly warned to migrate their code before the v1.0 major release.@deprecatedJSDoc tag touseAppConfigto display linting warnings and strikethroughs in IDEs.console.warn(omitted in production environments).Manual Testing
Related Issue
This PR fixes #2145