Minor improvements to EI patterns - #141
Conversation
|
Warning Review limit reached
More reviews will be available in 24 minutes and 6 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (17)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR makes small consistency and correctness tweaks across the “Enterprise Integration Patterns” samples in the WI default profile, mainly addressing typos, naming mismatches, and refactoring mapping/query logic into dedicated data_mappings.bal files.
Changes:
- Fixes several spelling/name inconsistencies (resource names, type names, variables, and function names).
- Refactors inline mapping/query logic into reusable mapping functions (new
data_mappings.balfiles). - Adjusts sample connectivity/config to align with the intended mock endpoints and dependencies.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| integrator-default-profile/enterprise-integration-pattern/routing_slip/main.bal | Fixes points call handling to assign the result to points instead of an incorrect http:Response variable. |
| integrator-default-profile/enterprise-integration-pattern/process_manager/main.bal | Fixes typo in DHL shipment function invocation. |
| integrator-default-profile/enterprise-integration-pattern/process_manager/functions.bal | Renames creeateDhlShipment to createDhlShipment for consistency. |
| integrator-default-profile/enterprise-integration-pattern/pipes_and_filters/main.bal | Fixes variable name typo (employeePerformance). |
| integrator-default-profile/enterprise-integration-pattern/message/connections.bal | Updates SurveyMonkey base URL to match the path used at the call site. |
| integrator-default-profile/enterprise-integration-pattern/message_translator/types.bal | Corrects Opportunity type name and its usage in SalesData. |
| integrator-default-profile/enterprise-integration-pattern/message_translator/functions.bal | Removes the old translate implementation (now relocated). |
| integrator-default-profile/enterprise-integration-pattern/message_translator/data_mappings.bal | Adds the translate mapping as an expression-bodied function. |
| integrator-default-profile/enterprise-integration-pattern/message_endpoint/types.bal | Fixes currency literal typo (GBP). |
| integrator-default-profile/enterprise-integration-pattern/message_endpoint/main.bal | Fixes resource name typo (convert). |
| integrator-default-profile/enterprise-integration-pattern/idempotent_receiver/main.bal | Makes orderStatuses persistent across requests by moving it to module scope. |
| integrator-default-profile/enterprise-integration-pattern/format_indicator/main.bal | Fixes request param typo and refactors V1 patient mapping into a helper. |
| integrator-default-profile/enterprise-integration-pattern/format_indicator/data_mappings.bal | Adds toPatient mapping helper for PatientReqV1. |
| integrator-default-profile/enterprise-integration-pattern/content_filter/main.bal | Extracts reimbursement filtering into a helper function. |
| integrator-default-profile/enterprise-integration-pattern/content_filter/data_mappings.bal | Adds filterReimbursements mapping helper. |
| integrator-default-profile/enterprise-integration-pattern/channel_adapter/Ballerina.toml | Adds the ballerinax/jira dependency required by the sample code. |
| integrator-default-profile/enterprise-integration-pattern/aggregator/main.bal | Makes partialSurveys persistent across requests by moving it to module scope. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,10 +1,11 @@ | |||
| import ballerina/http; | |||
|
|
|||
| map<OrderStatus> orderStatuses = {}; | |||
| @@ -1,10 +1,11 @@ | |||
| import ballerina/http; | |||
|
|
|||
| map<json[]> partialSurveys = {}; | |||
Purpose
This PR addresses some minor inconsistencies related to the EI patterns in WI default profile