Skip to content

Fix PHP minimum version readiness check - #40

Open
fetachino wants to merge 1 commit into
wp-media:trunkfrom
fetachino:fix/php-minimum-version
Open

Fix PHP minimum version readiness check#40
fetachino wants to merge 1 commit into
wp-media:trunkfrom
fetachino:fix/php-minimum-version

Conversation

@fetachino

Copy link
Copy Markdown

Closes #38.

Aligns check_readiness() with Composer's declared PHP 7.4 minimum and updates the runtime error message accordingly.

The readiness function now accepts an optional version argument so the compatibility boundary can be tested without depending on the PHP version running the suite. Unit coverage verifies that 7.4.0 is accepted and 7.3.99 produces the expected E_USER_ERROR.

Validation:

  • git diff --check — passed
  • PHP/Composer tests were not run locally because neither executable is installed on this Windows host; the repository CI matrix will exercise PHP 7.4 through 8.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP minimum version inconsistent: composer >=7.4 vs check_readiness() 7.1

1 participant