Update wp-cli framework#1086
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe framework update workflow now uses ChangesFramework update workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
8618187 to
2af5841
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2af5841 to
dfc54dd
Compare
dfc54dd to
38ecddc
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/update-framework.yml:
- Around line 29-32: Update the actions/checkout step in the update-framework
workflow to set persist-credentials to false, preventing GITHUB_TOKEN from being
stored in local git configuration. Preserve authentication for the later push by
configuring explicit credentials only in the git push step.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: eb640dac-5ff8-42ac-8aea-3ac6270cb4c0
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
.github/workflows/update-framework.yml
| - name: Check out source code | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| token: ${{ secrets.ACTIONS_BOT }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '--- file list ---\n'
git ls-files .github/workflows/update-framework.yml
printf '\n--- line count ---\n'
wc -l .github/workflows/update-framework.yml
printf '\n--- relevant excerpt ---\n'
sed -n '1,220p' .github/workflows/update-framework.ymlRepository: wp-cli/wp-cli-bundle
Length of output: 249
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '--- search for checkout usage and credential handling in workflow ---\n'
rg -n "actions/checkout|persist-credentials|GITHUB_TOKEN|GH_TOKEN|git push|composer" .github/workflows/update-framework.ymlRepository: wp-cli/wp-cli-bundle
Length of output: 249
🏁 Script executed:
#!/bin/bash
set -euo pipefail
sed -n '1,220p' .github/workflows/update-framework.ymlRepository: wp-cli/wp-cli-bundle
Length of output: 3450
Disable persisted checkout credentials. actions/checkout stores the GITHUB_TOKEN in local git config by default. This job runs Composer afterward, so a package script or plugin could read the write-capable token before the push step. Set persist-credentials: false and add explicit auth only for git push.
🧰 Tools
🪛 zizmor (1.26.1)
[warning] 29-32: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/update-framework.yml around lines 29 - 32, Update the
actions/checkout step in the update-framework workflow to set
persist-credentials to false, preventing GITHUB_TOKEN from being stored in local
git configuration. Preserve authentication for the later push by configuring
explicit credentials only in the git push step.
Sources: MCP tools, Linters/SAST tools
This is an automated pull-request
Updates the
wp-cli/wp-cliframework to the latest changeset.