Stabilize regex error Behat assertions across PHP/PCRE versions

[Copilot]

The failing test / Behat (8.3, trunk, mysql-8.0) job was caused by a brittle Behat expectation for invalid regex errors. The command output remained correct, but the asserted PCRE offset changed in newer PHP/PCRE builds.

• Problem

  • The regex delimiter scenario in features/search-replace.feature hard-coded at offset 11.
  • In the failing CI environment, the same invalid pattern now reports unmatched closing parenthesis at offset 12.

• Change

  • Updated the four invalid-regex assertions to match the stable part of the error message instead of an exact offset value.
  • This keeps coverage on the actual failure mode while avoiding false negatives from PHP/PCRE-specific offset differences.

• Result

  • The Behat scenario continues to verify that invalid regex input is rejected with the expected compilation error.
  • The CI check no longer depends on a version-sensitive byte offset.

And STDERR should contain:
  """
  unmatched closing parenthesis at offset 1
  """

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[swissspidy]

@copilot the modification helps make some tests pass, but they still fail on php 7.2:

001 Scenario: Search replace with a regex delimiter # features/search-replace.feature:463
      And STDERR should contain:                    # features/search-replace.feature:510
        $ wp search-replace 'regex error)' '' --regex
        
        Error: The regex pattern 'regex error)' with default delimiter 'chr(1)' and no flags fails.
        preg_match(): Compilation failed: unmatched parentheses at offset 11.
        cwd: /tmp/wp-cli-test-run--6a367f7e281a49.09614259/
        run time: 0.24805402755737
        exit status: 1
        
        Output does not contain expected string:
        unmatched closing parenthesis at offset 1
        
        --- Expected
        +++ Actual
        @@ @@
        -unmatched closing parenthesis at offset 1
        +Error: The regex pattern 'regex error)' with default delimiter 'chr(1)' and no flags fails.
        +preg_match(): Compilation failed: unmatched parentheses at offset 11.
         (Exception)

The assertion could use regex, e.g.

Then STDERR should match /.../

[Copilot]

@copilot the modification helps make some tests pass, but they still fail on php 7.2:

...

Addressed in ad8e0e0. I switched the four invalid-regex checks to STDERR should match /.../ with a pattern that accepts both unmatched parentheses and unmatched closing parenthesis, and no longer depends on a specific offset.

[Copilot]

Pull request overview

This PR stabilizes the Behat coverage around invalid-regex handling for wp search-replace by removing reliance on a PCRE-reported byte offset that can vary across PHP/PCRE versions.

Changes:

• Replaced four brittle STDERR should contain assertions (hard-coded at offset 11) with a regex-based assertion that accepts any numeric offset while still validating the underlying compilation failure.
• Kept the scenario focused on the specific failure mode (“unmatched closing parenthesis…”) while avoiding false negatives across environments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.