Skip to content

Fix failing theme tests - #540

Merged
swissspidy merged 2 commits into
mainfrom
fix/tests
Aug 6, 2026
Merged

Fix failing theme tests#540
swissspidy merged 2 commits into
mainfrom
fix/tests

Conversation

@swissspidy

@swissspidy swissspidy commented Aug 6, 2026

Copy link
Copy Markdown
Member

The moina theme requires PHP 7.4+ since yesterday, so some tests using that theme are now failing on PHP 7.2

This PR replaces the theme with oceanly and oceanly-green

Summary by CodeRabbit

  • Tests
    • Updated theme management scenarios to use the Oceanly and Oceanly Green themes.
    • Refreshed installation, update, deletion, activation, multisite, and parent-theme behavior checks.
    • Updated expected theme names, versions, URLs, paths, messages, and command output.
    • Replaced outdated Moina fixtures with Storefront coverage for theme installation, upgrades, and deletion.

@swissspidy swissspidy added this to the 3.0.1 milestone Aug 6, 2026
@swissspidy
swissspidy requested a review from a team as a code owner August 6, 2026 10:28
@swissspidy swissspidy added the scope:testing Related to testing label Aug 6, 2026
Copilot AI lite review requested due to automatic review settings August 6, 2026 10:28
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e3edc0a6-789e-4635-b31c-589422bf0c15

📥 Commits

Reviewing files that changed from the base of the PR and between 492894c and 74bc92b.

📒 Files selected for processing (2)
  • features/theme-update.feature
  • features/upgradables.feature
🚧 Files skipped from review as they are similar to previous changes (1)
  • features/theme-update.feature

📝 Walkthrough

Walkthrough

The feature scenarios replace Moina fixtures with Oceanly, Oceanly Green, and Storefront. Installation, deletion, update, multisite, parent-child, activation, and upgrade expectations now use the updated names, versions, URLs, and paths.

Changes

Theme fixture updates

Layer / File(s) Summary
Theme lifecycle scenarios
features/theme.feature, features/theme-delete.feature, features/theme-install.feature
Theme lifecycle scenarios now use oceanly and oceanly-green for installation, deletion, multisite, parent-child, and activation checks.
Theme update fixtures
features/theme-update.feature
Update scenarios now use Storefront version 1.0.0 and expect Updating Storefront....
Upgrade example data
features/upgradables.feature
The upgrade scenario now uses the Storefront 1.0.0 archive and stylesheet path.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: schlessera

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating theme tests to resolve failures caused by the removed or incompatible Moina fixtures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@features/theme-update.feature`:
- Line 53: Update the theme update scenario around the Oceanly installation and
subsequent wp theme update step so it no longer expects HTTP 404 for the
available 1.0.3 release; either use an unavailable release/build for the failure
case or assert the successful installation behavior when targeting version
1.0.3.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7635dfd8-0601-41c9-9875-19477087331c

📥 Commits

Reviewing files that changed from the base of the PR and between c54ca95 and 492894c.

📒 Files selected for processing (5)
  • features/theme-delete.feature
  • features/theme-install.feature
  • features/theme-update.feature
  • features/theme.feature
  • features/upgradables.feature

Comment thread features/theme-update.feature Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WP-CLI Behat acceptance tests to stop relying on the moina theme (which now requires PHP 7.4+) by switching the test fixtures to the oceanly parent theme and oceanly-green child theme.

Changes:

  • Replace moina with oceanly in upgradable/theme install/update test scenarios.
  • Replace moina-blog with oceanly-green in multisite enable/disable, parent/child, and delete-behavior scenarios.
  • Update expected output strings and file paths to match the new theme slugs/names.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
features/upgradables.feature Switches the theme used in the upgradables scenario outline from moina to oceanly (zip URL + file path assertions).
features/theme.feature Replaces multisite enable/disable and parent/child theme scenarios to use oceanly + oceanly-green, updating expected outputs and slugs accordingly.
features/theme-update.feature Updates theme install/update scenarios to use oceanly and adjusts expected “Updating …” output.
features/theme-install.feature Updates the parent/child install + cache behavior scenario to use oceanly + oceanly-green.
features/theme-delete.feature Updates delete scenarios involving an active child theme + parent to use oceanly-green and oceanly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy
swissspidy merged commit 84f9ccb into main Aug 6, 2026
117 of 118 checks passed
@swissspidy
swissspidy deleted the fix/tests branch August 6, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants