Fix failing theme tests - #540
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe feature scenarios replace Moina fixtures with Oceanly, Oceanly Green, and Storefront. Installation, deletion, update, multisite, parent-child, activation, and upgrade expectations now use the updated names, versions, URLs, and paths. ChangesTheme fixture updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@features/theme-update.feature`:
- Line 53: Update the theme update scenario around the Oceanly installation and
subsequent wp theme update step so it no longer expects HTTP 404 for the
available 1.0.3 release; either use an unavailable release/build for the failure
case or assert the successful installation behavior when targeting version
1.0.3.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 7635dfd8-0601-41c9-9875-19477087331c
📒 Files selected for processing (5)
features/theme-delete.featurefeatures/theme-install.featurefeatures/theme-update.featurefeatures/theme.featurefeatures/upgradables.feature
There was a problem hiding this comment.
Pull request overview
This PR updates the WP-CLI Behat acceptance tests to stop relying on the moina theme (which now requires PHP 7.4+) by switching the test fixtures to the oceanly parent theme and oceanly-green child theme.
Changes:
- Replace
moinawithoceanlyin upgradable/theme install/update test scenarios. - Replace
moina-blogwithoceanly-greenin multisite enable/disable, parent/child, and delete-behavior scenarios. - Update expected output strings and file paths to match the new theme slugs/names.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| features/upgradables.feature | Switches the theme used in the upgradables scenario outline from moina to oceanly (zip URL + file path assertions). |
| features/theme.feature | Replaces multisite enable/disable and parent/child theme scenarios to use oceanly + oceanly-green, updating expected outputs and slugs accordingly. |
| features/theme-update.feature | Updates theme install/update scenarios to use oceanly and adjusts expected “Updating …” output. |
| features/theme-install.feature | Updates the parent/child install + cache behavior scenario to use oceanly + oceanly-green. |
| features/theme-delete.feature | Updates delete scenarios involving an active child theme + parent to use oceanly-green and oceanly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The
moinatheme requires PHP 7.4+ since yesterday, so some tests using that theme are now failing on PHP 7.2This PR replaces the theme with
oceanlyandoceanly-greenSummary by CodeRabbit