fix(update-agent): validate unsigned claim source names and hashes - #1389
Open
Cr0wTom wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sourcesis not covered by the claim's manifest signature, andSource.name/hashflowed unvalidated intounique_name()→Path::join→ root-privileged file create/truncate — a tampered claim could write outside the downloads dir (../../etc/cron.d/x).Fix:
ClaimBuilder::buildrejects names that aren't a single ordinary path component and hashes that aren't 64 hex chars;make_component_pathre-checks at the point of use. Post-signaturewarn!s collect fleet data on name≠key and extra sources (future enforcement, ORBS-1347). No behavior change for valid claims.Tests: core accept/reject matrices + full-claim tests against the real parser with an in-test key (traversal name rejected under a valid signature).
cargo test -p orb-update-agent-coregreen; update-agent tests run in Linux CI.Mitigates: VULN-6328 (fixed); path element of VULN-6331/6332; external disclosure report (Sep 2026), source-name path traversal. Part 1/3 of claim hardening.
Update: reviewed by GPT-6 with no issues surfaced.