feat: refactor tests - #1385
Conversation
|
69c4a05 to
e75979f
Compare
|
No concrete correctness, security, race-condition, or regression issues found in the PR changes. |
e75979f to
81644d4
Compare
|
No concrete correctness, security, race-condition, or merge-blocking issues found in the PR changes. |
81644d4 to
278e2ee
Compare
|
No concrete correctness, security, race-condition, or regression issues found in the PR changes. |
278e2ee to
f4a2243
Compare
|
No concrete correctness bugs or merge-blocking issues found in the PR diff. The Tests were not run in the read-only environment. |
| .await | ||
| .unwrap(); | ||
|
|
||
| // put().await only confirms the message was sent, not that the remote |
There was a problem hiding this comment.
I have a suspicion this was on purpose?
@vmenge should review it.
Everything else looks very good to me.
There was a problem hiding this comment.
Yes, that was on purpose. I think there is a race in the test, and this change tries to fix it.
A bunch of small fixes:
test_orb_id()returing a pre-defined orb-id to be used only in tests.