fix(generated): Move organization connected-account operations onto Pipes - #733
Conversation
…iKeys, AuditLogs, Authorization, ClientApi, Connect, DirectorySync, Events, FeatureFlags, Groups, MultiFactorAuth, OrganizationDomains, OrganizationMembership, Organizations, Pipes, PipesProvider, PlatformTeams, Radar, SSO, UserManagement, Vault, Webhooks, Widgets
|
| AgentInstanceCreatedData as AgentInstanceCreatedData, | ||
| ) | ||
| from .agent_instance_created_data_type import * | ||
| from .agent_instance_deleted import AgentInstanceDeleted as AgentInstanceDeleted |
There was a problem hiding this comment.
Removing these wildcard exports drops unrelated enum classes and literal aliases from the public workos.common.models namespace, including DirectoryUserState and AgentInstanceCreatedDataType. Removing the parent wildcard also drops them from workos.common. The underlying modules still exist, but downstream imports such as from workos.common.models import DirectoryUserState now raise ImportError. Please restore explicit exports or include these additional removals in the declared breaking SDK surface change.
Knowledge Base Used: Product automation services
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/workos/common/models/__init__.py
Line: 57
Comment:
**Public Enum Exports Removed**
Removing these wildcard exports drops unrelated enum classes and literal aliases from the public `workos.common.models` namespace, including `DirectoryUserState` and `AgentInstanceCreatedDataType`. Removing the parent wildcard also drops them from `workos.common`. The underlying modules still exist, but downstream imports such as `from workos.common.models import DirectoryUserState` now raise `ImportError`. Please restore explicit exports or include these additional removals in the declared breaking SDK surface change.
**Knowledge Base Used:** [Product automation services](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-python/-/docs/product-automation-services.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary
fix(pipes): Move organization connected-account operations onto Pipes
The previous regeneration exposed the organization connected-account endpoints on a standalone
OrganizationsDataProvidersresource. That was the wrong home (workos/openapi-spec#179 corrects the service ownership), and it never shipped in a release. The same five endpoints are now on thePipesresource. Nothing was added to or removed from the API itself; only where the SDK exposes it changed.client.organizations_data_providers.get_organization_connected_accountclient.pipes.get_organization_connected_accountclient.organizations_data_providers.create_organization_connected_accountclient.pipes.create_organization_connected_accountclient.organizations_data_providers.update_organization_connected_accountclient.pipes.update_organization_connected_accountclient.organizations_data_providers.delete_organization_connected_accountclient.pipes.delete_organization_connected_accountclient.organizations_data_providers.list_organization_data_providersclient.pipes.list_organization_data_providersMethod names are unchanged; only the accessor moved. The async client follows the same change.
fix(multi_factor_auth): Change errors for endpoint
POST /auth/factors/{id}/challengePOST /auth/factors/{id}/challenge.Triggered by workos/openapi-spec@bfe7aed
BEGIN_COMMIT_OVERRIDE
fix(pipes): Move organization connected-account operations onto Pipes (#733)
fix(multi_factor_auth): Change errors for endpoint
POST /auth/factors/{id}/challenge(#733)END_COMMIT_OVERRIDE