Skip to content

feat(generated): SSO (batch 16283437) #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
workos-sdk-automation merged 2 commits into from
Jul 28, 2026
Merged

feat(generated): SSO (batch 16283437) #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76ff860
chore(generated): regenerate shared files for SSO
workos-sdk-automation[bot] Jul 28, 2026
d24dcee
chore(generated): add release notes fragment
workos-sdk-automation[bot] Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changelog-pending/2026-07-28T20-32-59-c7b77690a4486560659df08d947039af4cd52055.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
* [#426](https://github.com/workos/workos-php/pull/426) fix(generated): regenerate from spec

@greptile-apps greptile-apps Bot Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Breaking removal classified as fix

When consumers upgrade within the version range selected for fixes, removing the public Connection::$callbackEndpoint property and named constructor parameter causes undefined-property access or Unknown named parameter $callbackEndpoint errors, despite the changelog presenting this SDK surface break as an ordinary fix.

Knowledge Base Used: SSO and User Management authentication flows

Prompt To Fix With AI 
This is a comment left during a code review.
Path: .changelog-pending/2026-07-28T20-32-59-c7b77690a4486560659df08d947039af4cd52055.md
Line: 1

Comment:
**Breaking removal classified as fix**

When consumers upgrade within the version range selected for fixes, removing the public `Connection::$callbackEndpoint` property and named constructor parameter causes undefined-property access or `Unknown named parameter $callbackEndpoint` errors, despite the changelog presenting this SDK surface break as an ordinary fix.

**Knowledge Base Used:** [SSO and User Management authentication flows](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-php/-/docs/sso-and-user-management.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


**Fixes**
* **[sso](https://workos.com/docs/reference/sso)**:
* Removed `callback_endpoint` from `Connection`
2 changes: 1 addition & 1 deletion .last-synced-sha
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
904c5bccd2c6d0511ad2d0760e57d139143f1773
ae3ebbb08d9b4bf9b2391558e820b7eb6f511fb9
4 changes: 0 additions & 4 deletions lib/Resource/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ public function __construct(
public \DateTimeImmutable $updatedAt,
/** Unique identifier for the Organization in which the Connection resides. */
public ?string $organizationId = null,
/** The immutable callback endpoint for this Connection. For SAML connections this is the ACS URL; for OIDC connections this is the redirect URI. */
public ?string $callbackEndpoint = null,
) {
}

Expand All @@ -55,7 +53,6 @@ public static function fromArray(array $data): self
createdAt: new \DateTimeImmutable($data['created_at']),
updatedAt: new \DateTimeImmutable($data['updated_at']),
organizationId: $data['organization_id'] ?? null,
callbackEndpoint: $data['callback_endpoint'] ?? null,
);
}

Expand All @@ -72,7 +69,6 @@ public function toArray(): array
'created_at' => $this->createdAt->format(\DateTimeInterface::RFC3339_EXTENDED),
'updated_at' => $this->updatedAt->format(\DateTimeInterface::RFC3339_EXTENDED),
'organization_id' => $this->organizationId,
'callback_endpoint' => $this->callbackEndpoint,
];
}
}
2 changes: 1 addition & 1 deletion lib/Service/SSO.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public function deleteConnection(
* @param string|null $domainHint Can be used to pre-fill the domain field when initiating authentication with Microsoft OAuth or with a Google SAML connection type.
* @param string|null $loginHint Can be used to pre-fill the username/email address field of the IdP sign-in page for the user, if you know their username ahead of time. Currently supported for OAuth, OpenID Connect, Okta, Entra ID, and custom SAML connections.
* @param string|null $nonce A random string generated by the client that is used to mitigate replay attacks.
* @param string|null $prompt If set to `login`, forces re-authentication at the identity provider. For SAML connections this sets `ForceAuthn="true"` in the SAML request.
* @param string|null $prompt If set to `login`, forces re-authentication at the identity provider. For supported SAML providers this sets `ForceAuthn="true"` in the SAML request; providers that don't support it are unaffected.
* @return string
* @throws \WorkOS\Exception\ConfigurationException
*/
Expand Down
1 change: 0 additions & 1 deletion tests/Fixtures/connection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"domain": "foo-corp.com"
}
],
"callback_endpoint": "https://auth.workos.com/sso/saml/acs/conn_externalkey",
"created_at": "2026-01-15T12:00:00.000Z",
"updated_at": "2026-01-15T12:00:00.000Z"
}
1 change: 0 additions & 1 deletion tests/Fixtures/list_connection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"domain": "foo-corp.com"
}
],
"callback_endpoint": "https://auth.workos.com/sso/saml/acs/conn_externalkey",
"created_at": "2026-01-15T12:00:00.000Z",
"updated_at": "2026-01-15T12:00:00.000Z"
}
Expand Down