You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me, including the localization patching code from #25915. But, I'm surprised that the PR results part of 27.2.0.1 but the code is not in that beta's backmerge #25916.
@crazytonyli as such, I might wait for your input before approving and merging. Thanks!
Thanks for the review and the tip @crazytonyli . Funny enough, I had the action on your comment sitting on my machine but hadn't pushed it yet. Or, maybe that's not funny at all because you had to go and fix it... Anyway, glad to learn about the process and that this is landing. Sorry for the confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging
release/27.2intotrunk.Via intermediate branch
merge/release-27.2-into-trunk, to help fix conflicts if any: