Present the publish sheet as a form sheet in regular width - #25906
Open
crazytonyli wants to merge 1 commit into
Open
Present the publish sheet as a form sheet in regular width#25906crazytonyli wants to merge 1 commit into
crazytonyli wants to merge 1 commit into
Conversation
The publish sheet used a custom 526pt detent everywhere. UIKit only marks
a sheet as accessibility-modal while it rests at the large detent, and
over the editor's stacked modal presentations that left Voice Control
unable to reach any of the sheet's elements ("Show numbers" showed
nothing, CMM-2216). The partial-height sheet also added little on large
screens, where it already rendered as a centered card.
Keep the detented sheet in compact width and present a plain form sheet
in regular width, matching how Post Settings is presented from the
editor. Verified with Voice Control on an iPad running iPadOS 26.6.
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33811 | |
| Version | PR #25906 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 8dae63f | |
| Installation URL | 5ja9stca65m5g |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33811 | |
| Version | PR #25906 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 8dae63f | |
| Installation URL | 62d5mns4fdfm0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://linear.app/a8c/issue/CMM-2216
On iPad, the Publish Sheet is presented as a shorter form sheet, which can be dragged up to its large state (which looks like a form sheet). I believe this sheet presentation makes sense on iPhone, but not so much on iPad. This PR simplifies the iPad presentation to a regular form sheet.